Message-ID: <154e089b0901190303k46b9a223of08923ee11ed873b@mail.gmail.com>
Date: Mon, 19 Jan 2009 12:03:44 +0100
From: "Hannes Eder" <hannes@hanneseder.net>
To: "Stephen Rothwell" <sfr@canb.auug.org.au>
Subject: Re: [PATCH] creds: suppress warning in get_cred
Cc: "David Howells" <dhowells@redhat.com>, "James Morris" <jmorris@namei.org>,
       LKML <linux-kernel@vger.kernel.org>
In-Reply-To: <20090119211031.934b4c19.sfr@canb.auug.org.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20090119211031.934b4c19.sfr@canb.auug.org.au>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1495
Lines: 44

On Mon, Jan 19, 2009 at 11:10 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> This is the usual way to force a conversion from a const pointer to a
> non-const one and gets rid of this warning:
>
> include/linux/cred.h: In function 'get_cred':
> include/linux/cred.h:188: warning: passing argument 1 of 'get_new_cred' discards qualifiers from pointer target type
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  include/linux/cred.h |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/cred.h b/include/linux/cred.h
> index 3282ee4..ed38227 100644
> --- a/include/linux/cred.h
> +++ b/include/linux/cred.h
> @@ -12,6 +12,7 @@
>  #ifndef _LINUX_CRED_H
>  #define _LINUX_CRED_H
>
> +#include <linux/types.h>
>  #include <linux/capability.h>
>  #include <linux/key.h>
>  #include <asm/atomic.h>
> @@ -185,7 +186,7 @@ static inline struct cred *get_new_cred(struct cred *cred)
>  */
>  static inline const struct cred *get_cred(const struct cred *cred)
>  {
> -       return get_new_cred((struct cred *) cred);
> +       return get_new_cred((struct cred *)(uintptr_t)cred);
>  }
>
>  /**

This is most likly a compiler bug, see

http://lkml.org/lkml/2008/11/20/441 and followups.

-Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/