Message-ID: <497469AC.2030107@redhat.com>
Date: Mon, 19 Jan 2009 13:53:16 +0200
From: Avi Kivity <avi@redhat.com>
User-Agent: Thunderbird 2.0.0.19 (X11/20090105)
MIME-Version: 1.0
To: Sam Ravnborg <sam@ravnborg.org>
CC: Ingo Molnar <mingo@elte.hu>, Jaswinder Singh Rajput <jaswinder@kernel.org>,
       Andrew Morton <akpm@linux-foundation.org>,
       x86 maintainers <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL -tip v3] fix 39 'make headers_check' warnings
References: <1232287474.3130.19.camel@localhost.localdomain> <20090118185635.GA30514@elte.hu> <497445B6.7030606@redhat.com> <20090119110153.GA8321@uranus.ravnborg.org>
In-Reply-To: <20090119110153.GA8321@uranus.ravnborg.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1339
Lines: 38

Sam Ravnborg wrote:
>> They are.  This bits advertise to userspace what features kvm supports, 
>> both compile- and run-time.
>>     
>
> This is wrong...
> The headers does not change with the kernel configuration and advertising the
> kvm features via a .h file like this is simply plain broken.
>   

Ok.  Don't know why I thought unifdef was supplied with the full 
configuration.

> You cannot assume that the header files are generated with the exact same config
> as used by the running kernel.
>   

This is just for arch specific defines.  I'll move these to asm/kvm.h.

> And userspace has in no way access to the CONFIG_ namespace which is purely kernel-internal.
>
> I cannot see how you have ever seen kcm advertise that for example KVM_CAP_USER_NMI
> equals to 22 because CONFIG_X86 is never (supposed to be) defined in userspace -
> except if you did so yourself by some means.
>   

We did, we ship a hacked-up kvm.h (generated by unifdef) with our userspace.

Thanks for the clarifications, helpful as always.

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/