Date: Tue, 20 Jan 2009 01:52:51 +1100
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: David Howells <dhowells@redhat.com>
Cc: James Morris <jmorris@namei.org>, LKML <linux-kernel@vger.kernel.org>,
       "Hannes Eder" <hannes@hanneseder.net>
Subject: Re: [PATCH] creds: suppress warning in get_cred
Message-Id: <20090120015251.47ea14ff.sfr@canb.auug.org.au>
In-Reply-To: <11956.1232368171@redhat.com>
References: <20090119211031.934b4c19.sfr@canb.auug.org.au>
	<11956.1232368171@redhat.com>
Mime-Version: 1.0
Content-Type: multipart/signed; protocol="application/pgp-signature";
 micalg="PGP-SHA1";
 boundary="Signature=_Tue__20_Jan_2009_01_52_51_+1100_zbkffYhRR3suof0/"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1591
Lines: 48

--Signature=_Tue__20_Jan_2009_01_52_51_+1100_zbkffYhRR3suof0/
Content-Type: text/plain; charset=US-ASCII
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi David,

On Mon, 19 Jan 2009 12:29:31 +0000 David Howells <dhowells@redhat.com> wrot=
e:
>
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>=20
> > +	return get_new_cred((struct cred *)(uintptr_t)cred);
>=20
> That should probably be 'unsigned long' within the kernel.  This is also a
> compiler bug, but I think we can live with this fix.

We do have uintptr_t inside the kernel (it is typedeffed to unsigned
long) but I used it explicitly because its type is defined to be large
enough to store any pointer.

However, I have also verified that using a newer compiler (4.3.2 in my
case) makes the warning go away as Hannes Eder pointed out when
mentioning his earlier patch.

So, your choice.
--=20
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

--Signature=_Tue__20_Jan_2009_01_52_51_+1100_zbkffYhRR3suof0/
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkl0k8MACgkQjjKRsyhoI8z+qgCcCcZjiSqa9C8I+mo42M0gH6cu
T+gAoIYEeY8L1wIKI4KduicwHlSs3n7W
=noip
-----END PGP SIGNATURE-----

--Signature=_Tue__20_Jan_2009_01_52_51_+1100_zbkffYhRR3suof0/--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/