Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756729AbZASPBy (ORCPT ); Mon, 19 Jan 2009 10:01:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751919AbZASPBn (ORCPT ); Mon, 19 Jan 2009 10:01:43 -0500 Received: from e4.ny.us.ibm.com ([32.97.182.144]:53183 "EHLO e4.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751595AbZASPBm (ORCPT ); Mon, 19 Jan 2009 10:01:42 -0500 Subject: Re: [Ecryptfs-devel] [PATCH] ecryptfs: some inode attrs, and a question From: Dave Kleikamp To: hooanon05@yahoo.co.jp Cc: Tyler Hicks , linux-fsdevel , linux-kernel@vger.kernel.org, ecryptfs-devel@lists.launchpad.net In-Reply-To: <7087.1232331454@jrobl> References: <7471.1231827621@jrobl> <1231852628.6954.4.camel@norville.austin.ibm.com> <496FAFE2.8020102@linux.vnet.ibm.com> <9829.1232091366@jrobl> <1232125169.15209.19.camel@norville.austin.ibm.com> <7210.1232172192@jrobl> <1232210546.7015.8.camel@norville.austin.ibm.com> <10394.1232214142@jrobl> <1232215916.7015.78.camel@norville.austin.ibm.com> <7087.1232331454@jrobl> Content-Type: text/plain Date: Mon, 19 Jan 2009 09:01:35 -0600 Message-Id: <1232377295.5893.1.camel@norville.austin.ibm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.24.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 824 Lines: 22 On Mon, 2009-01-19 at 11:17 +0900, hooanon05@yahoo.co.jp wrote: > Dave Kleikamp: > > For a regular file, the size of the upper inode is not the same as the > > size of the lower inode. The lower inode includes the header blocks > > which are not visible in the upper inode. So ecryptfs_interpose() will > > overwrite the correct upper inode size. > > Then it means updating i_size in ecryptfs_link() is unnecessary... It's restoring i_size to the correct value after ecryptfs_interpose updates it with the wrong value. Shaggy -- David Kleikamp IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/