Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759919AbZASVZ4 (ORCPT ); Mon, 19 Jan 2009 16:25:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754468AbZASVZa (ORCPT ); Mon, 19 Jan 2009 16:25:30 -0500 Received: from rhun.apana.org.au ([64.62.148.172]:36930 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752433AbZASVZ0 (ORCPT ); Mon, 19 Jan 2009 16:25:26 -0500 Date: Tue, 20 Jan 2009 08:24:43 +1100 From: Herbert Xu To: David Miller Cc: w@1wt.eu, jarkao2@gmail.com, zbr@ioremap.net, dada1@cosmosbay.com, ben@zeus.com, mingo@elte.hu, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jens.axboe@oracle.com Subject: Re: [PATCH] tcp: splice as many packets as possible at once Message-ID: <20090119212443.GC6609@gondor.apana.org.au> References: <20090119061420.GB12946@1wt.eu> <20090118.221908.47032075.davem@davemloft.net> <20090119101924.GA1881@gondor.apana.org.au> <20090119.125941.240930524.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090119.125941.240930524.davem@davemloft.net> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 917 Lines: 23 On Mon, Jan 19, 2009 at 12:59:41PM -0800, David Miller wrote: . > And the difference between 64 and IPV4+TCP header len becomes the > payload, don't you see? :-) > > myri10ge just pulls min(64, skb->len) bytes from the SKB frags into > the linear area, unconditionally. So a small number of payload bytes > can in fact end up there. Ah, I thought they were doing a precise division. Yes pulling a constant length will trigger it if it's big enough. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/