Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761564AbZATP62 (ORCPT ); Tue, 20 Jan 2009 10:58:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755702AbZATP6U (ORCPT ); Tue, 20 Jan 2009 10:58:20 -0500 Received: from cantor.suse.de ([195.135.220.2]:39552 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752106AbZATP6T (ORCPT ); Tue, 20 Jan 2009 10:58:19 -0500 Message-ID: <4975F605.7030906@suse.de> Date: Wed, 21 Jan 2009 00:04:21 +0800 From: Coly Li Reply-To: coly.li@suse.de Organization: SuSE Labs User-Agent: Thunderbird 2.0.0.19 (X11/20090106) MIME-Version: 1.0 To: Dave Kleikamp Cc: LKML Subject: Re: [PATCH 11/20] fs/jfs: return f_fsid for statfs(2), v2 References: <49757804.4070305@suse.de> <1232454920.23109.5.camel@norville.austin.ibm.com> In-Reply-To: <1232454920.23109.5.camel@norville.austin.ibm.com> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1863 Lines: 55 Dave Kleikamp Wrote: > One minor nit... > Yeah, if there is no other device preempts major device number, it's almost no difference to huge_encode_dev() method in common cases. Anyway, using uuid a little better than v1 :) > On Tue, 2009-01-20 at 15:06 +0800, Coly Li wrote: >> This patch makes jfs return f_fsid info for statfs(2). By Andreas' suggestion, this patch populates >> a persistent f_fsid between boots/mounts with help of on-disk uuid record. >> >> Signed-off-by: Coly Li > > Acked-by: Dave Kleikamp > >> --- >> fs/jfs/super.c | 6 +++++- >> 1 files changed, 5 insertions(+), 1 deletions(-) >> >> diff --git a/fs/jfs/super.c b/fs/jfs/super.c >> index b37d1f7..6ce1aac 100644 >> --- a/fs/jfs/super.c >> +++ b/fs/jfs/super.c >> @@ -29,6 +29,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> >> @@ -168,7 +169,10 @@ static int jfs_statfs(struct dentry *dentry, struct kstatfs *buf) >> buf->f_files = maxinodes; >> buf->f_ffree = maxinodes - (atomic_read(&imap->im_numinos) - >> atomic_read(&imap->im_numfree)); >> - >> + buf->f_fsid.val[0] = (u32)crc32_le(0, sbi->uuid, sizeof(sbi->uuid)/2); >> + buf->f_fsid.val[1] = (u32)crc32_le(0, sbi->uuid + sizeof(sbi->uuid)/2, >> + sizeof(sbi->uuid)/2); >> + > > checkpatch.pl points out a trailing tab here > Oops, thanks for pointing out this. I will send out v3 and add your Acked-By in the patch. Thanks for review. -- Coly Li SuSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/