Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763504AbZAUEoU (ORCPT ); Tue, 20 Jan 2009 23:44:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757429AbZAUEoH (ORCPT ); Tue, 20 Jan 2009 23:44:07 -0500 Received: from wa-out-1112.google.com ([209.85.146.177]:55527 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756279AbZAUEoE (ORCPT ); Tue, 20 Jan 2009 23:44:04 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=jEHo2z5tFaRyp80mKg6WsfApZmsAicjqA08jfqIP/TxIWtobSJT8mEwHX/Qe3rib4A RITj1Q7FHTeKaK9XuwPLc7P+yXMMvVXjJ9JjItU0qIDtCA3+lhH1yeoEGr7BDh2xeJ3q 2OF7IDNKNYOwEGJHDPe1+ae19ZCPDEc1Zj8JM= MIME-Version: 1.0 In-Reply-To: <20090120235048.4f7200f9@caramujo.chehab.org> References: <1232502038.3123.61.camel@localhost.localdomain> <20090120235048.4f7200f9@caramujo.chehab.org> Date: Wed, 21 Jan 2009 10:14:03 +0530 Message-ID: <3f9a31f40901202044n73a100faj96a6f3d3973bcc25@mail.gmail.com> Subject: Re: Confusion in usr/include/linux/videodev.h From: Jaswinder Singh Rajput To: Mauro Carvalho Chehab Cc: Jaswinder Singh Rajput , linux-media@vger.kernel.org, video4linux-list@redhat.com, Sam Ravnborg , Ingo Molnar , LKML Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1979 Lines: 50 On Wed, Jan 21, 2009 at 7:20 AM, Mauro Carvalho Chehab wrote: > On Wed, 21 Jan 2009 07:10:38 +0530 > Jaswinder Singh Rajput wrote: > >> usr/include/linux/videodev.h is giving 2 warnings in 'make headers_check': >> usr/include/linux/videodev.h:19: leaks CONFIG_VIDEO to userspace where it is not valid >> usr/include/linux/videodev.h:314: leaks CONFIG_VIDEO to userspace where it is not valid >> >> Whole file is covered with #if defined(CONFIG_VIDEO_V4L1_COMPAT) || !defined (__KERNEL__) >> >> It means this file is only valid for kernel mode if CONFIG_VIDEO_V4L1_COMPAT is defined but in user mode it is always valid. >> >> Can we choose some better alternative Or can we use this file as: >> >> #ifdef CONFIG_VIDEO_V4L1_COMPAT >> #include >> #endif > > This is somewhat like what we have on audio devices (where there are OSS and ALSA API's). > > V4L1 is the old deprecated userspace API for video devices. It is still > required by some userspace applications. So, on userspace, it should be > included. Also, this allows that one userspace app to be compatible with both > V4L2 API (the current one) and the legacy V4L1 one. > > It should be noticed that are still a few drivers using the legacy API yet to > be converted. > If you have no objections then I will make a patchset which do followings: 1. Remove #if defined(CONFIG_VIDEO_V4L1_COMPAT) || !defined (__KERNEL__) from include/linux/videodev.h 2. cover all #include with #ifdef CONFIG_VIDEO_V4L1_COMPAT in kernel By this way, we can satisfy both kernel space and userspace issue and also get rid of above warnings. If you have better suggestion then let me know. Thanks, -- JSR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/