Date: Wed, 21 Jan 2009 11:14:00 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Tejun Heo <htejun@gmail.com>
Cc: Brian Gerst <brgerst@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] x86: Merge hardirq.h
Message-ID: <20090121101400.GE18728@elte.hu>
References: <73c1f2160901160610l57e31a64j56fe9544bd2fd309@mail.gmail.com> <1232457345-12366-5-git-send-email-brgerst@gmail.com> <4976DA9C.7000500@kernel.org> <4976E1CF.9050801@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4976E1CF.9050801@gmail.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1033
Lines: 26


* Tejun Heo <htejun@gmail.com> wrote:

> Tejun Heo wrote:
> > Brian Gerst wrote:
> >> Remove unused idle_timestamp field from 32-bit.
> > 
> > Dropped.  X86_32 doesn't build.  X86_64 UP doesn't build.  Please at
> > least do compile testing on all four combinations before sending the
> > patches.
> 
> One more thing, can you please split the patch into two such that the 
> merging and renaming happen as separate steps so that git can tell that 
> a file has been renamed instead of oh two of those disappeared and this 
> one popped up?  It's a bit tedious but makes log tracking much easier.

yes, we do that for all unification patches - the 'large patch' must 
always be a simple "git mv", with nothing modified inbetween. That way 
it's reviewable and debuggable as well.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/