Date: Wed, 21 Jan 2009 14:47:22 -0800 (PST)
Message-Id: <20090121.144722.52306013.davem@davemloft.net>
To: tklein@de.ibm.com
Cc: jeff@garzik.org, raisch@de.ibm.com, ossthema@de.ibm.com,
       themann@de.ibm.com, linux-kernel@vger.kernel.org,
       linuxppc-dev@ozlabs.org, netdev@vger.kernel.org, hering2@de.ibm.com
Subject: Re: [PATCH 3/3] ehea: Improve driver behaviour in low mem
 conditions
From: David Miller <davem@davemloft.net>
In-Reply-To: <200901211549.41352.tklein@de.ibm.com>
References: <200901211549.41352.tklein@de.ibm.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 849
Lines: 21

From: Thomas Klein <tklein@de.ibm.com>
Date: Wed, 21 Jan 2009 15:49:41 +0100

> Reworked receive queue fill policies to make the driver more tolerant
> in low memory conditions.
> 
> Signed-off-by: Thomas Klein <tklein@de.ibm.com>

Applied, but there is an even better way to handle this.

You should be allocating replacement RX skbs at receive time.  And if
the RX allocation fails, you simply give the RX skb back to the chip
and do not pass it up into the stack.

This is what many ethernet drivers do to ensure that the chip never
can reach a situation where the free RX packet queue becomes empty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/