From: "Tosoni" <jp.tosoni@acksys.fr>
To: "'Michael Bramer'" <michael@debsupport.de>,
       "'Alan Cox'" <alan@lxorguk.ukuu.org.uk>
Cc: "'Niels de Vos'" <niels.devos@wincor-nixdorf.com>,
       "'Paulius Zaleckas'" <paulius.zaleckas@teltonika.lt>,
       <linux-kernel@vger.kernel.org>, <linux-serial@vger.kernel.org>
Subject: RE: [PATCH] drivers/serial/8250_pci.c (add support for '8-port RS-232 MIC-3620 from advantech'
Date: Thu, 22 Jan 2009 09:21:17 +0100
Message-ID: <6E0880DF84464BF2AA0275ABFFCCDAF2@acksys.local>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
In-Reply-To: <20090121234241.GB10645@deb-support.de>
Importance: Normal
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1291
Lines: 35

> [mailto:linux-serial-owner@vger.kernel.org]On Behalf Of Michael Bramer
>
> On Wed, Jan 21, 2009 at 12:32:15PM +0000, Alan Cox wrote:
> > > >>  static struct pci_device_id serial_pci_tbl[] = {
> > > >> +       {       PCI_VENDOR_ID_ADVANTECH,
> PCI_DEVICE_ID_ADVANTECH_PCI3620,
> > > >> +               0x3620, PCI_ANY_ID, 0, 0,
> > >
> > > Why not use PCI_VENDOR_ID_ADVANTECH as PCI_SUBVENDOR_ID too?
> >
> > The Advantech vendor id is not 0x3620. This confused me as
> well which is
> > why I asked for an lspci. Advantech has stuck the device id in the
> > subvendor bits and '1' in the subdevice (so it should be 1 not
> > PCI_ANY_ID).
>
> is this better?
>
> +       {       PCI_VENDOR_ID_ADVANTECH,
> PCI_DEVICE_ID_ADVANTECH_PCI3620,
> +               PCI_DEVICE_ID_ADVANTECH_PCI3620, 1, 0, 0,

Since the name describes a device id where it should be a (sub)vendor id,
I would suggest that you add a line of comment to explain the case.
So that no one will be tempted to change it back to PCI_VENDOR_ID_ADVANTECH
in the future.

Regards


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/