Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757737AbZAVVLS (ORCPT ); Thu, 22 Jan 2009 16:11:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751546AbZAVVLH (ORCPT ); Thu, 22 Jan 2009 16:11:07 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:52545 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751102AbZAVVLG (ORCPT ); Thu, 22 Jan 2009 16:11:06 -0500 Date: Thu, 22 Jan 2009 22:10:53 +0100 From: Pavel Machek To: Sandro Bonazzola Cc: Pekka J Enberg , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH] w35und: fix usb_control_msg() error handling in wb35_probe() Message-ID: <20090122211052.GA1928@elf.ucw.cz> References: <20090122114237.GA13845@atrey.karlin.mff.cuni.cz> <4978C812.90702@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4978C812.90702@gmail.com> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1887 Lines: 50 On Thu 2009-01-22 20:25:06, Sandro Bonazzola wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Pavel Machek ha scritto: > >> From: Pekka Enberg > >> > >> If successful, the usb_control_msg() function returns the number of > >> bytes transferred. Fix up wb35_probe() to only bail out if the function > >> returns a negative number. > >> > >> Reported-by: Sandro Bonazzola > >> Signed-off-by: Pekka Enberg > > > > Acked-by: Pavel Machek > > Ok, tested. Here is the result: > > # uname -a > Linux arilinn 2.6.29-rc2-00013-gf3b8436-dirty #1 Thu Jan 22 19:39:23 CET 2009 > x86_64 AMD Athlon(tm) 64 Processor 3500+ AuthenticAMD GNU/Linux > > Inserting the USB device: > # dmesg > usb 1-3: new high speed USB device using ehci_hcd and address 4 > usb 1-3: New USB device found, idVendor=18e8, idProduct=6201 > usb 1-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3 > usb 1-3: Product: Usb2Wlan > usb 1-3: Manufacturer: WINBOND > usb 1-3: SerialNumber: 101d350112 > usb 1-3: configuration #1 chosen from 1 choice > w35und: module is from the staging directory, the quality is unknown, you have > been warned. > wmaster0 (usb): not using net_device_ops yet ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ This looks like a key clue... Maybe you could try _current_ w35und on 2.6.28 or something like that? I have feeling that networking core changed in incompatible way here. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/