Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759105AbZAVWc0 (ORCPT ); Thu, 22 Jan 2009 17:32:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752750AbZAVWcS (ORCPT ); Thu, 22 Jan 2009 17:32:18 -0500 Received: from fg-out-1718.google.com ([72.14.220.154]:38799 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752676AbZAVWcS (ORCPT ); Thu, 22 Jan 2009 17:32:18 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=SG2VoAeWLZAhrz4sZbVC1zLAMbibrl60ZfhaaqshTuepQfwMkaQWx1zy4HlYV4rZCU sYgcpj6qaH/niEXAOwCYrVbornn0QXo3djilugGgd0zka31Cz1c0Mg8YWUA2rG3mGFFU xzJMJOypM5MZLuZxyqJJn0E6tGGjWQL3SXxBU= MIME-Version: 1.0 In-Reply-To: <1232659146.9701.76.camel@brick> References: <20090122114237.GA13845@atrey.karlin.mff.cuni.cz> <4978C812.90702@gmail.com> <20090122211052.GA1928@elf.ucw.cz> <1232659146.9701.76.camel@brick> Date: Fri, 23 Jan 2009 00:32:15 +0200 X-Google-Sender-Auth: b8f146417b32877c Message-ID: <84144f020901221432wc745037s84e992161490712@mail.gmail.com> Subject: Re: [PATCH] w35und: fix usb_control_msg() error handling in wb35_probe() From: Pekka Enberg To: Harvey Harrison Cc: Pavel Machek , Sandro Bonazzola , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2303 Lines: 57 On Thu, Jan 22, 2009 at 11:19 PM, Harvey Harrison wrote: > On Thu, 2009-01-22 at 22:10 +0100, Pavel Machek wrote: >> On Thu 2009-01-22 20:25:06, Sandro Bonazzola wrote: >> > -----BEGIN PGP SIGNED MESSAGE----- >> > Hash: SHA1 >> > >> > Pavel Machek ha scritto: >> > >> From: Pekka Enberg >> > >> >> > >> If successful, the usb_control_msg() function returns the number of >> > >> bytes transferred. Fix up wb35_probe() to only bail out if the function >> > >> returns a negative number. >> > >> >> > >> Reported-by: Sandro Bonazzola >> > >> Signed-off-by: Pekka Enberg >> > > >> > > Acked-by: Pavel Machek >> > >> > Ok, tested. Here is the result: >> > >> > # uname -a >> > Linux arilinn 2.6.29-rc2-00013-gf3b8436-dirty #1 Thu Jan 22 19:39:23 CET 2009 >> > x86_64 AMD Athlon(tm) 64 Processor 3500+ AuthenticAMD GNU/Linux >> > >> > Inserting the USB device: >> > # dmesg >> > usb 1-3: new high speed USB device using ehci_hcd and address 4 >> > usb 1-3: New USB device found, idVendor=18e8, idProduct=6201 >> > usb 1-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3 >> > usb 1-3: Product: Usb2Wlan >> > usb 1-3: Manufacturer: WINBOND >> > usb 1-3: SerialNumber: 101d350112 >> > usb 1-3: configuration #1 chosen from 1 choice >> > w35und: module is from the staging directory, the quality is unknown, you have >> > been warned. >> > wmaster0 (usb): not using net_device_ops yet >> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> >> This looks like a key clue... >> >> Maybe you could try _current_ w35und on 2.6.28 or something like that? >> I have feeling that networking core changed in incompatible way here. >> > > I thought the net-device-ops conversion was opt in? It shouldn't break > anything if the driver hasn't been converted yet. Looking at commit d314774cf2cd5dfeb39a00d37deee65d4c627927 ("netdev: network device operations infrastructure") that seems to be the case. Pekka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/