Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760309AbZAWQBZ (ORCPT ); Fri, 23 Jan 2009 11:01:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759050AbZAWQA6 (ORCPT ); Fri, 23 Jan 2009 11:00:58 -0500 Received: from hera.kernel.org ([140.211.167.34]:34123 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756994AbZAWQA4 (ORCPT ); Fri, 23 Jan 2009 11:00:56 -0500 Subject: Re: [GIT PULL -tip] fix 33 make headers_check warnings From: Jaswinder Singh Rajput To: "H. Peter Anvin" Cc: Sam Ravnborg , David Woodhouse , Ingo Molnar , x86 maintainers , urs.thuermann@volkswagen.de, oliver.hartkopp@volkswagen.de, linux-media@vger.kernel.org, netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org, bfields@fieldses.org, neilb@suse.de, linux-nfs@vger.kernel.org, linux-raid@vger.kernel.org, dbrownell@users.sourceforge.net, spi-devel-general@lists.sourceforge.net, netdev@vger.kernel.org, greg@kroah.com, linux-usb@vger.kernel.org, linux-mtd@lists.infradead.org, tiwai@suse.de, mchehab@infradead.org, LKML , Andrew Morton In-Reply-To: <1232498319.3123.34.camel@localhost.localdomain> References: <1232223441.3966.22.camel@localhost.localdomain> <1232228261.27094.0.camel@macbook.infradead.org> <20090117221932.GA4956@uranus.ravnborg.org> <49725B1E.604@kernel.org> <1232498319.3123.34.camel@localhost.localdomain> Content-Type: text/plain Date: Fri, 23 Jan 2009 21:29:19 +0530 Message-Id: <1232726359.3504.18.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.24.2 (2.24.2-3.fc10) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1417 Lines: 46 On Wed, 2009-01-21 at 06:08 +0530, Jaswinder Singh Rajput wrote: > On Sat, 2009-01-17 at 14:26 -0800, H. Peter Anvin wrote: > > Sam Ravnborg wrote: > > >>> > > >> That patch looks wrong, and unnecessary. It was fine before. > > > Nope - include/linux/dvb/audio.h failed to include linux/types.h > > > despite the fact that is uses __u32 etc. > > > > > > But why the _kernel_ should include a userspace header is > > > much more questionable. > > > > > > > is one of a handful of headers provided by gcc itself. > > > > Should I reintroduce my patch to solve this warning of 'make headers_check': > usr/include/linux/dvb/audio.h:133: found __[us]{8,16,32,64} type without #include > > diff --git a/include/linux/dvb/audio.h b/include/linux/dvb/audio.h > index 89412e1..758a48c 100644 > --- a/include/linux/dvb/audio.h > +++ b/include/linux/dvb/audio.h > @@ -24,9 +24,8 @@ > #ifndef _DVBAUDIO_H_ > #define _DVBAUDIO_H_ > > -#ifdef __KERNEL__ > #include > -#else > +#ifndef __KERNEL__ > #include > #endif > It seems one have objection for this. So I will again insert this in my new patchset. -- JSR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/