Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932122AbZAWSLY (ORCPT ); Fri, 23 Jan 2009 13:11:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756865AbZAWSLG (ORCPT ); Fri, 23 Jan 2009 13:11:06 -0500 Received: from rtr.ca ([76.10.145.34]:58528 "EHLO mail.rtr.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755096AbZAWSLE (ORCPT ); Fri, 23 Jan 2009 13:11:04 -0500 Message-ID: <497A0836.5060707@rtr.ca> Date: Fri, 23 Jan 2009 13:11:02 -0500 From: Mark Lord Organization: Real-Time Remedies Inc. User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: Robert Hancock Cc: michael@ellerman.id.au, Grant Grundler , Daniel Barkalow , IDE/ATA development list , Linux Kernel , Tejun Heo , Jeff Garzik , linux-pci@vger.kernel.org Subject: Re: libata, devm_*, and MSI ? References: <4975F5C1.8090107@rtr.ca> <497698E2.7090807@rtr.ca> <1232511378.11241.64.camel@localhost> <4977399F.7000104@rtr.ca> <4977BED4.6010702@shaw.ca> In-Reply-To: <4977BED4.6010702@shaw.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1764 Lines: 49 Robert Hancock wrote: > Mark Lord wrote: >> Michael Ellerman wrote: >>> On Tue, 2009-01-20 at 20:02 -0800, Grant Grundler wrote: >> .. .. >>> The kernel shouldn't let you enable MSI if that's the case, ie. >>> pci_enable_msi() should fail. >> .. >> Exactly. So it shouldn't be that, then. >> >>> It might still be worth looking at the quirks though, in case there's >>> one for a previous revision of your bridge or something. >>> >>>> 3) Make sure MMIO ranges for 0xfee00000 are routed to local APIC >>>> ie each bridge needs to route that address somehow (negative decode >>>> is common for upstream). >>>> 4) manually trigger the MSI by doing a MMIO write to the correct >>>> 0xfee00000 address with the assigned vector in order to see if your >>>> interrupt handler gets called. >>> >>> And can you plug something directly into the PCIe bus? If so does MSI >>> work on that? >> .. >> >> Yup. PCIe cards have no problem with MSI in that box. >> >> More later.. > > What kind of PCI-X bridge does that machine have? I know some AMD > HyperTransport to PCI-X bridges have broken MSI, but those should be > blacklisted already in the kernel.. .. Okay, I'm back looking at this now. In the interim, the box has undergone a complete re-install, and I think the original boot logs are gone for good. Now (with 2.6.28.1), the boot code identifies a quirk, and pci_enable_msi() does indeed fail where it once succeeded. So all is well, but I don't know why it wasn't working correctly earlier. Oh well. Cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/