Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751869AbZAXGQe (ORCPT ); Sat, 24 Jan 2009 01:16:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750812AbZAXGQZ (ORCPT ); Sat, 24 Jan 2009 01:16:25 -0500 Received: from wa-out-1112.google.com ([209.85.146.177]:27200 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750803AbZAXGQY (ORCPT ); Sat, 24 Jan 2009 01:16:24 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=Vxe7X1+Ymwg08AVE5IFQdSr05NpQ/OXtxUK+ClD/gx05+tTWfQANjKJIiK1D/JBMsi 1l3dJlzkyZpfeTWJ6h2pFmkWaFX1EKDva8HY618gHjSxcuDZtHXUe9IYWcc4TavREoGs B64oxOKphFUOMH0+MMeGG0s7+gDpBxXcXubVs= MIME-Version: 1.0 In-Reply-To: <497469AC.2030107@redhat.com> References: <1232287474.3130.19.camel@localhost.localdomain> <20090118185635.GA30514@elte.hu> <497445B6.7030606@redhat.com> <20090119110153.GA8321@uranus.ravnborg.org> <497469AC.2030107@redhat.com> Date: Sat, 24 Jan 2009 11:46:22 +0530 Message-ID: <3f9a31f40901232216r4656776mfac4388485180a60@mail.gmail.com> Subject: Re: [GIT PULL -tip v3] fix 39 'make headers_check' warnings From: Jaswinder Singh Rajput To: Avi Kivity Cc: Sam Ravnborg , Ingo Molnar , Jaswinder Singh Rajput , Andrew Morton , x86 maintainers , LKML Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1868 Lines: 55 On Mon, Jan 19, 2009 at 5:23 PM, Avi Kivity wrote: > Sam Ravnborg wrote: >>> >>> They are. This bits advertise to userspace what features kvm supports, >>> both compile- and run-time. >>> >> >> This is wrong... >> The headers does not change with the kernel configuration and advertising >> the >> kvm features via a .h file like this is simply plain broken. >> > > Ok. Don't know why I thought unifdef was supplied with the full > configuration. > >> You cannot assume that the header files are generated with the exact same >> config >> as used by the running kernel. >> > > This is just for arch specific defines. I'll move these to asm/kvm.h. > >> And userspace has in no way access to the CONFIG_ namespace which is >> purely kernel-internal. >> >> I cannot see how you have ever seen kcm advertise that for example >> KVM_CAP_USER_NMI >> equals to 22 because CONFIG_X86 is never (supposed to be) defined in >> userspace - >> except if you did so yourself by some means. >> > > We did, we ship a hacked-up kvm.h (generated by unifdef) with our userspace. > latest -tip is still giving 'make headers_check' warnings: usr/include/linux/kvm.h:61: leaks CONFIG_X86 to userspace where it is not valid usr/include/linux/kvm.h:64: leaks CONFIG_X86 to userspace where it is not valid usr/include/linux/kvm.h:387: leaks CONFIG_X86 to userspace where it is not valid usr/include/linux/kvm.h:391: leaks CONFIG_X86 to userspace where it is not valid usr/include/linux/kvm.h:396: leaks CONFIG_X86 to userspace where it is not valid So should I resend my patch or you are going to move this stuff -- JSR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/