Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756192AbZAXXvT (ORCPT ); Sat, 24 Jan 2009 18:51:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752065AbZAXXvI (ORCPT ); Sat, 24 Jan 2009 18:51:08 -0500 Received: from mail-ew0-f10.google.com ([209.85.219.10]:50906 "EHLO mail-ew0-f10.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751629AbZAXXvH (ORCPT ); Sat, 24 Jan 2009 18:51:07 -0500 X-Greylist: delayed 318 seconds by postgrey-1.27 at vger.kernel.org; Sat, 24 Jan 2009 18:51:06 EST MIME-Version: 1.0 In-Reply-To: <20090124185612.5afddbb0@mjolnir.drzeus.cx> References: <1231268198-12556-1-git-send-email-apw@canonical.com> <20090112160519.3ba21848@mjolnir.drzeus.cx> <20090115150003.GB6896@shadowen.org> <20090124185612.5afddbb0@mjolnir.drzeus.cx> Date: Sun, 25 Jan 2009 00:45:46 +0100 Message-ID: Subject: Re: [PATCH 1/1] mmc: add MODALIAS linkage for MMC/SD devices From: Kay Sievers To: Pierre Ossman Cc: Andy Whitcroft , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1300 Lines: 31 On Sat, Jan 24, 2009 at 18:56, Pierre Ossman wrote: > On Thu, 15 Jan 2009 15:00:03 +0000 > Andy Whitcroft wrote: > >> >> Would it make more sense to simply use mmc: with no data as the MODALIAS >> tag here. And make mmc-block have mmc:* as an alias. That way the >> actual (useless) numeric data is not exposed but we still will load the >> mmc-block module for everything exactly as we do with the udev rule. >> This should still make things work from a distro point of view and not >> expose anything which might then get relied on. If we do it so extra >> data can still be added later we won't prevent sane data being exposed >> should we ever have any. >> >> If you are happier with that I can re-spin the patches that way? >> > > Well, as long as we're on the track of temporary hack, we might as well > just export "mmc_block" as the modalias. Or would there be any > side-effects to that? The common format is to prefix with ":". Something like "mmc:block" sounds fine to me. Thanks, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/