Date: Sun, 25 Jan 2009 17:57:10 +0100 (CET)
From: Jiri Kosina <jkosina@suse.cz>
To: Jaswinder Singh Rajput <jaswinderlinux@gmail.com>
cc: Jiri Slaby <jirislaby@gmail.com>,
       Dmitry Torokhov <dmitry.torokhov@gmail.com>,
       linux-input@vger.kernel.org, marcel@holtmann.org,
       linux-kernel@vger.kernel.org, anssi.hannula@gmail.com, gregkh@suse.de,
       Sam Ravnborg <sam@ravnborg.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 09/10] HID: add compat support
In-Reply-To: <3f9a31f40901232155q7f898f00l9a1cf16ca6c8fb75@mail.gmail.com>
Message-ID: <alpine.LNX.1.10.0901251756200.5377@jikos.suse.cz>
References: <1210931362-18422-1-git-send-email-jirislaby@gmail.com>  <1210931362-18422-2-git-send-email-jirislaby@gmail.com>  <1210931362-18422-3-git-send-email-jirislaby@gmail.com>  <1210931362-18422-4-git-send-email-jirislaby@gmail.com> 
 <1210931362-18422-5-git-send-email-jirislaby@gmail.com>  <1210931362-18422-6-git-send-email-jirislaby@gmail.com>  <1210931362-18422-7-git-send-email-jirislaby@gmail.com>  <1210931362-18422-8-git-send-email-jirislaby@gmail.com> 
 <1210931362-18422-9-git-send-email-jirislaby@gmail.com> <3f9a31f40901232155q7f898f00l9a1cf16ca6c8fb75@mail.gmail.com>
User-Agent: Alpine 1.10 (LNX 962 2008-03-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1236
Lines: 37

On Sat, 24 Jan 2009, Jaswinder Singh Rajput wrote:

> This leads to 3 headers_check warnings:
> 
>  usr/include/linux/hid.h:66: leaks CONFIG_HID to userspace where it is not valid
>  usr/include/linux/hid.h:69: extern's make no sense in userspace
>  usr/include/linux/hid.h:76: extern's make no sense in userspace
> 
> So I  am moving whole above block in #ifdef __KEREL__
> 
> If you have any objections, then let me know, now it will look like this:
> 
>  #endif /* HID_FF */
> 
> +#ifdef __KERNEL__
>  #ifdef CONFIG_HID_COMPAT
>  #define HID_COMPAT_LOAD_DRIVER(name)   \
>  /* prototype to avoid sparse warning */        \
> @@ -804,6 +805,7 @@ EXPORT_SYMBOL(hid_compat_##name)
>         extern void hid_compat_##name(void);    \
>         hid_compat_##name();                    \
>  } while (0)
> +#endif /* __KERNEL__ */
> 
>  #endif

Thanks for catching this. Could you please resend the patch to me, with 
proper changelog and Signed-off-by: line? Thanks.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/