Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753140AbZAZMQa (ORCPT ); Mon, 26 Jan 2009 07:16:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751305AbZAZMQV (ORCPT ); Mon, 26 Jan 2009 07:16:21 -0500 Received: from mtagate3.de.ibm.com ([195.212.29.152]:36323 "EHLO mtagate3.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750768AbZAZMQU (ORCPT ); Mon, 26 Jan 2009 07:16:20 -0500 Date: Mon, 26 Jan 2009 13:16:14 +0100 From: Heiko Carstens To: Mike Travis Cc: Stephen Rothwell , Andrew Morton , linux-next@vger.kernel.org, LKML , Martin Schwidefsky Subject: Re: [PATCH] sysrq: include interrupt.h instead of irq.h Message-ID: <20090126131614.4ad29c15@osiris.boeblingen.de.ibm.com> In-Reply-To: <4977523B.6000507@sgi.com> References: <20090121150249.a87aca09.sfr@canb.auug.org.au> <1232545758.31303.2.camel@osiris.boeblingen.de.ibm.com> <4977523B.6000507@sgi.com> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.12.11; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1620 Lines: 45 On Wed, 21 Jan 2009 08:50:03 -0800 Mike Travis wrote: > Thanks for catching this Heiko! > Mike Erm... it still breaks. Are you going to add the patch to your tree? > Heiko Carstens wrote: > > From: Heiko Carstens > > > > With "cpumask: update irq_desc to use cpumask_var_t" in linux-next > > we get this compile bug on s390: > > > > CC drivers/char/sysrq.o > > In file included from drivers/char/sysrq.c:38: > > include/linux/irq.h: In function 'init_alloc_desc_masks': > > include/linux/irq.h:442: error: dereferencing pointer to incomplete type > > > > drivers/char/sysrq.c should include interrupt.h instead of irq.h. > > > > Cc: Mike Travis > > Cc: Martin Schwidefsky > > Signed-off-by: Heiko Carstens > > --- > > drivers/char/sysrq.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Index: linux-next/drivers/char/sysrq.c > > =================================================================== > > --- linux-next.orig/drivers/char/sysrq.c > > +++ linux-next/drivers/char/sysrq.c > > @@ -35,7 +35,7 @@ > > #include > > #include > > #include > > -#include > > +#include > > #include > > #include -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/