Subject: Re: [RFC][PATCH 2/2] add a counter for writers spinning on a rwlock
From: Peter Zijlstra <peterz@infradead.org>
To: Mandeep Baines <msb@google.com>
Cc: =?ISO-8859-1?Q?Fr=E9d=E9ric?= Weisbecker <fweisbec@gmail.com>,
       Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org,
       Andrew Morton <akpm@linux-foundation.org>
In-Reply-To: <1fe6c7900901260936g63ea73a4naf1b90190352d057@mail.gmail.com>
References: <497cd08f.0c11660a.33a7.ffffdf39@mx.google.com>
	 <1232977715.4863.81.camel@laptop>
	 <c62985530901260725s2f36c6d8u1572775d790e7888@mail.gmail.com>
	 <1232984248.4863.106.camel@laptop>
	 <c62985530901260804o4022e0c0t5acba3f7c32c48ac@mail.gmail.com>
	 <1fe6c7900901260936g63ea73a4naf1b90190352d057@mail.gmail.com>
Content-Type: text/plain
Date: Mon, 26 Jan 2009 18:41:41 +0100
Message-Id: <1232991701.4863.222.camel@laptop>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1039
Lines: 31

On Mon, 2009-01-26 at 09:36 -0800, Mandeep Baines wrote:

> Unfortunately, this can't be done for hung_task. It writes to the
> task_struct here:

Don't top post!

> static void check_hung_task(struct task_struct *t, unsigned long now,
>                             unsigned long timeout)
> {
>         unsigned long switch_count = t->nvcsw + t->nivcsw;
> 
>         if (t->flags & PF_FROZEN)
>                 return;
> 
>         if (switch_count != t->last_switch_count || !t->last_switch_timestamp) {
>                 t->last_switch_count = switch_count;
>                 t->last_switch_timestamp = now;
>                 return;
>         }
> 
> It is able to get away with using only a read_lock because no one else
> reads or writes to these fields.

How would RCU be different here?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/