Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753150AbZAZSIS (ORCPT ); Mon, 26 Jan 2009 13:08:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751857AbZAZSIF (ORCPT ); Mon, 26 Jan 2009 13:08:05 -0500 Received: from courier.cs.helsinki.fi ([128.214.9.1]:48086 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751806AbZAZSIE (ORCPT ); Mon, 26 Jan 2009 13:08:04 -0500 Message-ID: <497DFB04.1040802@cs.helsinki.fi> Date: Mon, 26 Jan 2009 20:03:48 +0200 From: Pekka Enberg User-Agent: Thunderbird 2.0.0.19 (Macintosh/20081209) MIME-Version: 1.0 To: Greg KH CC: Pavel Machek , Sandro Bonazzola , linux-kernel@vger.kernel.org Subject: Re: [PATCH] w35und: fix usb_control_msg() error handling in wb35_probe() References: <20090126175115.GA29205@kroah.com> In-Reply-To: <20090126175115.GA29205@kroah.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 780 Lines: 21 Greg KH wrote: > On Thu, Jan 22, 2009 at 12:06:33PM +0200, Pekka J Enberg wrote: >> From: Pekka Enberg >> >> If successful, the usb_control_msg() function returns the number of >> bytes transferred. Fix up wb35_probe() to only bail out if the function >> returns a negative number. >> >> Reported-by: Sandro Bonazzola >> Signed-off-by: Pekka Enberg > > I'm confused, should I apply this patch or not? Yes, you should. What's confusing you here? Pekka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/