Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751904AbZAZSLS (ORCPT ); Mon, 26 Jan 2009 13:11:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751968AbZAZSKp (ORCPT ); Mon, 26 Jan 2009 13:10:45 -0500 Received: from nf-out-0910.google.com ([64.233.182.187]:63242 "EHLO nf-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751613AbZAZSKo (ORCPT ); Mon, 26 Jan 2009 13:10:44 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=ol2kLmUygTBEMs7AJ8zslpCEmfgcRpCGA9nVsOLphoxHLkZ35Oj4PsgtdImGN0NzV8 iLpwdUIkH2kWeBTkXMJnwKhpAopSOksh23oQOaYNEZ4899zgA4+DboccUD25xIlRWNPA WVFJDVe5Rhl/0uRtymM87YXY3rD5fieJiRB44= MIME-Version: 1.0 In-Reply-To: <497DFB04.1040802@cs.helsinki.fi> References: <20090126175115.GA29205@kroah.com> <497DFB04.1040802@cs.helsinki.fi> Date: Mon, 26 Jan 2009 20:10:42 +0200 X-Google-Sender-Auth: 2b022ebe293927d8 Message-ID: <84144f020901261010h67958566lbd9ea240dc6d9ec@mail.gmail.com> Subject: Re: [PATCH] w35und: fix usb_control_msg() error handling in wb35_probe() From: Pekka Enberg To: Greg KH Cc: Pavel Machek , Sandro Bonazzola , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1028 Lines: 26 On Mon, Jan 26, 2009 at 8:03 PM, Pekka Enberg wrote: > Greg KH wrote: >> >> On Thu, Jan 22, 2009 at 12:06:33PM +0200, Pekka J Enberg wrote: >>> >>> From: Pekka Enberg >>> >>> If successful, the usb_control_msg() function returns the number of >>> bytes transferred. Fix up wb35_probe() to only bail out if the function >>> returns a negative number. >>> >>> Reported-by: Sandro Bonazzola >>> Signed-off-by: Pekka Enberg >> >> I'm confused, should I apply this patch or not? > > Yes, you should. What's confusing you here? Oh, looking at the thread, I see how you got confused. The patch doesn't fix all of Sandro's problems but is an obvious improvement so it should be merged. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/