Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753456AbZAZSYS (ORCPT ); Mon, 26 Jan 2009 13:24:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751621AbZAZSYJ (ORCPT ); Mon, 26 Jan 2009 13:24:09 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:34021 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751548AbZAZSYI (ORCPT ); Mon, 26 Jan 2009 13:24:08 -0500 Date: Mon, 26 Jan 2009 10:23:39 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Dave Airlie cc: dri-devel@lists.sf.net, Linux Kernel Mailing List , Jesse Barnes Subject: Re: [git pull] drm-fixes In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1947 Lines: 48 Dave, you have some odd and slightly git usage model, which shows up in various commits. Lookie here as an example from comit 335041ed: Author: Jesse Barnes 2009-01-22 04:22:06 Committer: Dave Airlie 2009-01-22 04:22:06 drm/i915: hook up LVDS DPMS property The LVDS output supports DPMS calls, but we never hooked up the property code, so set property calls didn't actually do anything. Implement a set_property callback for the LVDS output so that the right thing happens. Signed-off-by: Jesse Barnes and this has a few issues that trigger my "Dave is doing something wrong" reaction: - The signed-off-chain is incomplete from the author to the committer. A _good_ sign-off will always have the sign-offs from the author and the committer and everybody in between. This one does not. Clearly Jesse did sign off on his work, but he is not listed as the committer: you are. And that means that your sign-off is missing. - You are clearly lying about dates and/or dropping them. The dates for authorship and committing are the same, yet the author and committer are clearly _not_ the same. You can try to convince me that you committed Jesse's work the same second he sent it to you, but quite frankly, I don't buy it. End result: you've done something to drop the date information. I don't know what tools you use, or what process the patches go through, but I do know that whatever your process is, it's losing information. Please fix it. I've pulled, but I hope I won't have to see these issues in future pull requests. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/