DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=CcS7jAlAP0batZJibVIQGWwAPPsRM3+cq82SK0y03sCfSIJGaIQ2cpaVND/RXiE6NXv/Sb8EgInLxcfMvvl4Qe5/KAZx6sOq3ibFpYZLYuHbTTX57SLoQWcLY5JBp7Ae0j0+Tr6tSahT1O+EFmnKh34+93Q+fRFJW6JgJhRCqAQ=  ;
From: David Brownell <david-b@pacbell.net>
To: Ed Swierk <eswierk@aristanetworks.com>
Subject: Re: [PATCH] rtc-ds1307: True SMBus compatibility
Date: Mon, 26 Jan 2009 13:06:20 -0800
User-Agent: KMail/1.9.10
Cc: Jean Delvare <khali@linux-fr.org>, linux-i2c@vger.kernel.org,
       Alessandro Zummo <a.zummo@towertech.it>, linux-kernel@vger.kernel.org,
       Andrew Morton <akpm@linux-foundation.org>,
       BARRE Sebastien <sbarre@sdelcc.com>
References: <1231177261.13443.20.camel@localhost.localdomain> <20090120114304.3b956189@hyperion.delvare> <1232951630.1329.4.camel@localhost.localdomain>
In-Reply-To: <1232951630.1329.4.camel@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200901261306.21059.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1251
Lines: 36

On Sunday 25 January 2009, Ed Swierk wrote:
> Here's another attempt at a patch for rtc-ds1307 that allows the driver
> to work with SMBus controllers like nforce2 that do not support i2c
> block transfers.  The byte-oriented compatibility routines now give up
> after 10 unsuccessful attempts to read or write a block of registers
> without conflict.
> 
> Signed-off-by: Ed Swierk <eswierk@aristanetworks.com>

Well, other than the *conceptual* ugliness of this (which
we seem to be stuck with, courtesy the board designer) ...
I have two patch format issues:

 - Always put a line of whitespace after variable
   declarations.

 - Include text like the above as part of the patch,
   even if you're stuck with a mailer that mangles
   non-attached text.

You're using Evolution, which is mentioned in the
Documentation/email-clients.txt file as having a
way (albeit awkward) to send normal patch email.

Given those changes:

  Acked-by: David Brownell <dbrownell@users.sourceforge.net>

Thanks.

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/