Message-ID: <497E28EA.8060504@msgid.tls.msk.ru>
Date: Tue, 27 Jan 2009 00:19:38 +0300
From: Michael Tokarev <mjt@tls.msk.ru>
Organization: Telecom Service, JSC
User-Agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103)
MIME-Version: 1.0
To: Eric Paris <eparis@redhat.com>
CC: linux-kernel@vger.kernel.org, sgrubb@redhat.com, esandeen@redhat.com,
       sukadev@us.ibm.com, alan@lxorguk.ukuu.org.uk
Subject: Re: tty: tty_open can return to userspace holding tty_mutex
References: <1233003761.9850.14.camel@localhost.localdomain>
In-Reply-To: <1233003761.9850.14.camel@localhost.localdomain>
Content-Type: text/plain; charset=KOI8-R
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1365
Lines: 41

Eric Paris wrote:
> __tty_open could return (to userspace) holding the tty_mutex thanks to a
> regression introduced by 4a2b5fddd53b80efcb3266ee36e23b8de28e761a.  This was
> found by bisecting an fsfuzzer problem.  Admittedly I have no idea how it
> managed to tickle this 100% reliably, but it is clearly a regression and
> when hit leaves the box in a completely unusable state.  This patch lets
> the fsfuzzer test complete every time.

This should go to -stable too, right?
It's present in 2.6.28 (but not 2.6.27).

/mjt

> Signed-off-by: Eric Paris <eparis@redhat.com>
> 
> ---
>  drivers/char/tty_io.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c
> index d33e5ab..bc84e12 100644
> --- a/drivers/char/tty_io.c
> +++ b/drivers/char/tty_io.c
> @@ -1817,8 +1817,10 @@ got_driver:
>  		/* check whether we're reopening an existing tty */
>  		tty = tty_driver_lookup_tty(driver, inode, index);
>  
> -		if (IS_ERR(tty))
> +		if (IS_ERR(tty)) {
> +			mutex_unlock(&tty_mutex);
>  			return PTR_ERR(tty);
> +		}
>  	}
>  
>  	if (tty) {

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/