Date: Mon, 26 Jan 2009 21:16:55 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: lirc@bartelmus.de (Christoph Bartelmus), linux-kernel@vger.kernel.org,
       Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] export get_task_comm()
Message-Id: <20090126211655.c7287768.akpm@linux-foundation.org>
In-Reply-To: <20090128140615.D464.KOSAKI.MOTOHIRO@jp.fujitsu.com>
References: <20090120071641.B0A3.KOSAKI.MOTOHIRO@jp.fujitsu.com>
	<AuEeLWHZjFB@christoph>
	<20090128140615.D464.KOSAKI.MOTOHIRO@jp.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1906
Lines: 54

On Tue, 27 Jan 2009 14:09:05 +0900 (JST) KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:

> > Hi,
> > 
> > on 19 Jan 09 at 07:36, KOSAKI Motohiro wrote:
> > >> is there any reason why get_task_comm() is not exported in fs/exec.c?
> > 
> > > In general, the only function of anybody necessarity explained is exported.
> > > if you want to export get_task_comm(), you need to explain reasonable
> > > reason.
> > 
> > It's nothing that important: just want to print the executable name to the  
> > logs during error handling. get_task_comm() is the required accessor  
> > function.
> > 
> > http://lirc.cvs.sourceforge.net/viewvc/lirc/lirc/drivers/lirc_dev/lirc_dev.c?revision=1.70&view=markup
> 
> To be honest, I don't use get_task_comm(). but I don't oppose your request.
> 
> ==
> Subject: [PATCH] export get_task_comm()
> 
> task::comm is good debugging information and driver developer want to
> use this information easily.
> 
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> ---
>  fs/exec.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> Index: b/fs/exec.c
> ===================================================================
> --- a/fs/exec.c
> +++ b/fs/exec.c
> @@ -936,6 +936,7 @@ char *get_task_comm(char *buf, struct ta
>  	task_unlock(tsk);
>  	return buf;
>  }
> +EXPORT_SYMBOL_GPL(get_task_comm);
>  
>  void set_task_comm(struct task_struct *tsk, char *buf)
>  {

Ho hum, I suppose so.  I redid the changelog a bit:

   task_struct.comm[] is useful for debugging and driver developers
   want to use this information easily.  Direct access to
   task_struct.comm[] is a bit racy, so export the official accessor.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/