Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754017AbZA0F3w (ORCPT ); Tue, 27 Jan 2009 00:29:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751678AbZA0F3l (ORCPT ); Tue, 27 Jan 2009 00:29:41 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:44656 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751553AbZA0F3k (ORCPT ); Tue, 27 Jan 2009 00:29:40 -0500 Date: Mon, 26 Jan 2009 21:29:18 -0800 From: Andrew Morton To: Kyle McMartin , KOSAKI Motohiro , Christoph Bartelmus , linux-kernel@vger.kernel.org, Linus Torvalds , Andy Whitcroft Subject: Re: [PATCH] export get_task_comm() Message-Id: <20090126212918.d4770115.akpm@linux-foundation.org> In-Reply-To: <20090126212615.2658b29e.akpm@linux-foundation.org> References: <20090120071641.B0A3.KOSAKI.MOTOHIRO@jp.fujitsu.com> <20090128140615.D464.KOSAKI.MOTOHIRO@jp.fujitsu.com> <20090126211655.c7287768.akpm@linux-foundation.org> <20090127051919.GA5034@bombadil.infradead.org> <20090126212615.2658b29e.akpm@linux-foundation.org> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1077 Lines: 28 On Mon, 26 Jan 2009 21:26:15 -0800 Andrew Morton wrote: > On Tue, 27 Jan 2009 00:19:19 -0500 Kyle McMartin wrote: > > > On Mon, Jan 26, 2009 at 09:16:55PM -0800, Andrew Morton wrote: > > > Ho hum, I suppose so. I redid the changelog a bit: > > > > > > task_struct.comm[] is useful for debugging and driver developers > > > want to use this information easily. Direct access to > > > task_struct.comm[] is a bit racy, so export the official accessor. > > > > > > > Maybe lirc should be submitted to staging/ before we go exporting > > symbols for out of tree things... ;-) > > y:/usr/src/linux-2.6.29-rc2> grep -r 'current->comm' drivers | wc -l > 77 > > :( It's worth a checkpatch rule, I guess: "direct access to task_struct.comm is racy - use get_task_comm()". -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/