Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754405AbZA0LQs (ORCPT ); Tue, 27 Jan 2009 06:16:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752462AbZA0LQk (ORCPT ); Tue, 27 Jan 2009 06:16:40 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:59422 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752220AbZA0LQj (ORCPT ); Tue, 27 Jan 2009 06:16:39 -0500 Date: Tue, 27 Jan 2009 12:16:31 +0100 From: Ingo Molnar To: Takashi Iwai Cc: Jean Delvare , Rufus & Azrael , Linux-kernel Mailing List , Jaswinder Singh Rajput Subject: Re: [2.6.29-rc2-git2] compilation warnings Message-ID: <20090127111631.GB17848@elte.hu> References: <497EB491.6080904@numericable.fr> <20090127094628.670eca16@hyperion.delvare> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1764 Lines: 45 * Takashi Iwai wrote: > At Tue, 27 Jan 2009 09:46:28 +0100, > Jean Delvare wrote: > > > > On Tue, 27 Jan 2009 08:32:17 +0100, Takashi Iwai wrote: > > > At Tue, 27 Jan 2009 08:15:29 +0100, > > > Rufus & Azrael wrote: > > > > > > > > Here are my compilation warnings for fresh 2.6.29-rc2-git2 kernel : > > > > > > > > > sound/pci/hda/hda_codec.c: In function ‘get_empty_pcm_device’: > > > > > sound/pci/hda/hda_codec.c:2544: attention : ‘dev’ may be used > > > > > uninitialized in this function > > > > > > A bogus warning. Ignore this. > > > > No matter how bogus it is, it should be fixed. Otherwise this is > > wasting the time of users and developers over and over again. > > Well, it's a bug of gcc appearing only in a certain version, so most > people won't see it. > > Of course, we can put uninitialized_var(). But, I don't basically like > adding it unconditionally... People will again and again look at this warning and waste time deciding that "it's a bogus warning" or even report it. As time goes on does the human cost get larger, linearly. Furthermore, if everyone in the kernel behaves like that we'll literally have dozens (even hundreds) of build warnings that might be bogus but which also obscure other, real warnings by their sheer mass. The cost of you adding a oneliner annotation is miniscule compared to that and it is a one-time effort. We already spent more energy on discussing this than it would have taken you to annotate it. Please. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/