Date: Tue, 27 Jan 2009 17:16:18 -0500
From: Christoph Hellwig <hch@infradead.org>
To: Jing Huang <huangj@brocade.com>
Cc: James.Bottomley@HansenPartnership.com, kgudipat@brocade.com,
       linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
       rvadivel@brocade.com, vravindr@brocade.com
Subject: Re: [PATCH 2/5] bfa: Brocade BFA FC SCSI driver submission
Message-ID: <20090127221618.GA26480@infradead.org>
References: <200901271854.n0RIs73a026759@swe37.brocade.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200901271854.n0RIs73a026759@swe37.brocade.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 914
Lines: 28

On Tue, Jan 27, 2009 at 10:54:07AM -0800, Jing Huang wrote:
> +/**
> + * Generic HAL callback element.
> + */
> +struct bfa_cb_qe_s {
> +	struct bfa_q_s         qe;
> +	bfa_cb_cbfn_t  cbfn;
> +	bfa_boolean_t   once;
> +	u32		rsvd;
> +	void           *cbarg;
> +};
> +
> +#define bfa_cb_queue(__bfa, __hcb_qe, __cbfn, __cbarg) do {		\
> +	(__hcb_qe)->cbfn  = (__cbfn);					\
> +	(__hcb_qe)->cbarg = (__cbarg);					\
> +	bfa_q_enq(&(__bfa)->comp_q, (__hcb_qe));			\
> +} while (0)

Please stop here, weird HALs and own list management routines are not
things we put into the tree.  (except for gregs junk subdirectory..)

Please rewrite this into a proper Linux driver.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/