Message-ID: <497FD9CD.1090202@schaufler-ca.com>
Date: Tue, 27 Jan 2009 20:06:37 -0800
From: Casey Schaufler <casey@schaufler-ca.com>
User-Agent: Thunderbird 2.0.0.19 (Windows/20081209)
MIME-Version: 1.0
To: LKLM <linux-kernel@vger.kernel.org>,
       LSM <linux-security-module@vger.kernel.org>, jmorris@namei.org
CC: "Ahmed S. Darwish" <darwish.07@gmail.com>, akpm@linux-foundation.org,
       torvalds@linux-foundation.org
Subject: [PATCH] smackfs load append mode fix - resend unmundged.
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1132
Lines: 33

From: Casey Schaufler <casey@schaufler-ca.com>

Given just how hard it is to find the code that uses MAY_APPEND
it's probably not a big surprise that this went unnoticed for so
long. The Smack rules loading code is incorrectly setting the
MAY_READ bit when MAY_APPEND is requested.

Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>

---

security/smack/smackfs.c |    2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff -uprN -X linux-2.6/Documentation/dontdiff linux-2.6/security/smack/smackfs.c linux-0112/security/smack/smackfs.c
--- linux-2.6/security/smack/smackfs.c	2009-01-09 21:43:42.000000000 -0800
+++ linux-0112/security/smack/smackfs.c	2009-01-19 11:05:09.000000000 -0800
@@ -334,7 +334,7 @@ static ssize_t smk_write_load(struct fil
		break;
	case 'a':
	case 'A':
-		rule.smk_access |= MAY_READ;
+		rule.smk_access |= MAY_APPEND;
		break;
	default:
		goto out;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/