From: Rusty Russell <rusty@rustcorp.com.au>
To: Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] module: kzalloc mod->ref
Date: Wed, 28 Jan 2009 22:54:50 +1030
User-Agent: KMail/1.10.3 (Linux/2.6.27-9-generic; KDE/4.1.3; i686; ; )
Cc: Takashi Iwai <tiwai@suse.de>, Ingo Molnar <mingo@redhat.com>,
       Tejun Heo <tj@kernel.org>, Kyle McMartin <kyle@infradead.org>,
       linux-kernel@vger.kernel.org, Eric Dumazet <dada1@cosmosbay.com>
References: <20090114033533.GL25103@bombadil.infradead.org> <200901271206.51248.rusty@rustcorp.com.au> <20090127131534.GG23121@elte.hu>
In-Reply-To: <20090127131534.GG23121@elte.hu>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200901282254.51238.rusty@rustcorp.com.au>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 996
Lines: 31

On Tuesday 27 January 2009 23:45:34 Ingo Molnar wrote:
> 
> * Rusty Russell <rusty@rustcorp.com.au> wrote:
> 
> > @@ -344,8 +339,11 @@ struct module
> >  	/* Destruction function. */
> >  	void (*exit)(void);
> >  
> > -	/* Reference counts */
> > -	struct module_ref ref[NR_CPUS];
> > +#ifdef CONFIG_SMP
> > +	char *refptr;
> > +#else
> > +	local_t ref;
> > +#endif
> 
> hm, that construct looks rather ugly. Is there no way to provide a clean 
> data type and APIs for this that just work symmetrically on both SMP and 
> UP?

Part of me agreed when I first read it, but unification means UP would do an alloc as well.  Neater, but less efficient.

But maybe these days UP means embedded, and hence no modules anyway :)

Hope that clarifies,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/