Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754736AbZA1SVE (ORCPT ); Wed, 28 Jan 2009 13:21:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751132AbZA1SUx (ORCPT ); Wed, 28 Jan 2009 13:20:53 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:48993 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751104AbZA1SUw (ORCPT ); Wed, 28 Jan 2009 13:20:52 -0500 Subject: Re: Buggy IPI and MTRR code on low memory From: Peter Zijlstra To: Steven Rostedt Cc: LKML , Linus Torvalds , Ingo Molnar , Thomas Gleixner , Andrew Morton , Arjan van de Ven , Rusty Russell , jens.axboe@oracle.com In-Reply-To: References: <1233161182.10992.52.camel@laptop> Content-Type: text/plain Date: Wed, 28 Jan 2009 19:20:34 +0100 Message-Id: <1233166834.10992.61.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1228 Lines: 29 On Wed, 2009-01-28 at 12:24 -0500, Steven Rostedt wrote: > On Wed, 28 Jan 2009, Peter Zijlstra wrote: > > --- > > Subject: x86: fix potential deadlock in set_mtrr() > > From: Peter Zijlstra > > Date: Wed Jan 28 17:17:32 CET 2009 > > > > smp_call_function() can fall-back to waiting on completion in case of > > low memory (GFP_ATOMIC). set_mtrr() relies on the async behaviour of !wait. > > > > This would deadlock. > > > > Fix this by providing per-cpu csd's and using __smp_call_function_single(). > > I applied the patch but it still locked up in the testing NMI > watchdog code. Not saying your patch is at fault, because we never made it > to your code. This is probably not an issue, since if we have low memory > at bootup, we have much bigger problems to deal with. > > I'll have skip the NMI test and see if it locks up any place else. Right, the NMI code does exactly the same, in that case your patch might well be the best way forward. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/