Subject: Re: [PATCH] firmware: speed up request_firmware()
From: Matt Mackall <mpm@selenic.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Ira Snyder <iws@ovro.caltech.edu>, linux-kernel@vger.kernel.org
In-Reply-To: <20090128181117.35fb319b@lxorguk.ukuu.org.uk>
References: <20090128180446.GB31107@ovro.caltech.edu>
	 <20090128181117.35fb319b@lxorguk.ukuu.org.uk>
Content-Type: text/plain
Date: Wed, 28 Jan 2009 12:35:22 -0600
Message-Id: <1233167722.18091.2.camel@calx>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 896
Lines: 21

On Wed, 2009-01-28 at 18:11 +0000, Alan Cox wrote:
> > Without this patch, loading a 12MB firmware image (FPGA bitfiles) called
> > vmalloc() approximately 3000 times. With the patch, vmalloc() is only
> > called 13 times, however, some memory is wasted until firmware_release() is
> > called. Usually, this happens very quickly, so it shouldn't be a problem.
> 
> Particularly on 32bit x86 vmalloc memory space is very precious so while
> the current buffer size default may be too small doubling repeatedly is
> not a good model IMHO.

How about a small exponent like 1.1?

-- 
http://selenic.com : development and support for Mercurial and Linux


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/