Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756775AbZA1WOp (ORCPT ); Wed, 28 Jan 2009 17:14:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751390AbZA1WOc (ORCPT ); Wed, 28 Jan 2009 17:14:32 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:45024 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751318AbZA1WOb (ORCPT ); Wed, 28 Jan 2009 17:14:31 -0500 Date: Wed, 28 Jan 2009 14:13:35 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Harvey Harrison cc: "H. Peter Anvin" , "H. Peter Anvin" , Arnd Bergmann , Jaswinder Singh Rajput , Ingo Molnar , Linux Kernel Mailing List , Andrew Morton , Sam Ravnborg , Jaswinder Singh Rajput , "David S. Miller" Subject: Re: [PATCH] x86: do not expose CONFIG_BSWAP to userspace In-Reply-To: <1233179884.6717.59.camel@brick> Message-ID: References: <20090127222825.GA27097@elte.hu> <1233106614.3256.6.camel@localhost.localdomain> <200901281337.52294.arnd@arndb.de> <49809A65.2090501@kernel.org> <1233170532.6717.49.camel@brick> <1233172994.6717.56.camel@brick> <4980CD51.70601@zytor.com> <1233179884.6717.59.camel@brick> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 837 Lines: 31 On Wed, 28 Jan 2009, Harvey Harrison wrote: > > Use ifdef __i486__ to ensure the BSWAP instruction is available > on 32-bit x86. > > Signed-off-by: Harvey Harrison > --- > HPA, > > I'm afraid my knowledge of gcc compiler flags for various models is > lacking, I used i486 as suggested, just wanted to make sure I understood > you corectly. I really don't think this works. Try this: cpp -dM -m32 -march=pentium t.c | grep i486 and see the marked absense of __i486__ anywhere. At least CONFIG_X86_BSWAP gives the right behaviour for the kernel. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/