Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754673AbZA1WlZ (ORCPT ); Wed, 28 Jan 2009 17:41:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751637AbZA1WlQ (ORCPT ); Wed, 28 Jan 2009 17:41:16 -0500 Received: from casper.infradead.org ([85.118.1.10]:38648 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751364AbZA1WlP (ORCPT ); Wed, 28 Jan 2009 17:41:15 -0500 Date: Wed, 28 Jan 2009 14:41:14 -0800 From: Arjan van de Ven To: Rusty Russell Cc: linux-kernel@vger.kernel.org, Shawn Bohrer , Jon Masters Subject: Re: [PATCH 5/6] module: make modversion_info contain a pointer, not an array. Message-ID: <20090128144114.4aeaa0ff@infradead.org> In-Reply-To: <200901290859.40725.rusty@rustcorp.com.au> References: <200901290005.52819.rusty@rustcorp.com.au> <20090128065231.64d12ffd@infradead.org> <200901290859.40725.rusty@rustcorp.com.au> Organization: Intel X-Mailer: Claws Mail 3.7.0 (GTK+ 2.14.5; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1497 Lines: 40 On Thu, 29 Jan 2009 08:59:40 +1030 Rusty Russell wrote: > On Thursday 29 January 2009 01:22:31 Arjan van de Ven wrote: > > On Thu, 29 Jan 2009 00:05:52 +1030 > > Rusty Russell wrote: > > > > > > > > With allmodconfig (minus non-building modules) on 32-bit x86: > > > Total size of modules before: 60009790 bytes > > > Total size of modules after: 55927866 bytes > > > > > > Saving 7% of module size for CONFIG_MODVERSIONS=y; and these > > > sections are kept resident as well. > > > > > > > that reminds me.. can we just simplify MODVERSIONS to be a md5sum > > (or sha1 whatver) of the .config file in the VERMAGIC ? > > it's a lot more reliable in detecting incompatibilities, and a lot > > less space consumed. > > Unfortunately people really seem to want the finer granularity that > MODVERSIONS (sometimes) provides :( I've tried killing it off > several times, and always failed. but we could just stick the result in VERMAGIC right? rather than tacking it to every symbol. how you calculate the global checksum is almost a separate debate. -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/