Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755837AbZA1XOI (ORCPT ); Wed, 28 Jan 2009 18:14:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752176AbZA1XNz (ORCPT ); Wed, 28 Jan 2009 18:13:55 -0500 Received: from einhorn.in-berlin.de ([192.109.42.8]:33158 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752102AbZA1XNy (ORCPT ); Wed, 28 Jan 2009 18:13:54 -0500 X-Envelope-From: stefanr@s5r6.in-berlin.de Date: Thu, 29 Jan 2009 00:13:20 +0100 (CET) From: Stefan Richter Subject: [PATCH revised] ieee1394: sbp2: add workarounds for 2nd and 3rd generation iPods To: linux1394-devel@lists.sourceforge.net cc: Jarod Wilson , linux-kernel@vger.kernel.org In-Reply-To: Message-ID: References: <200901281718.41873.jarod@redhat.com> <200901281725.25750.jarod@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; CHARSET=us-ascii Content-Disposition: INLINE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1372 Lines: 42 as per https://bugs.launchpad.net/bugs/294391. These got one sample of each iPod generation going. However there still occurred I/O stalls with the 3rd generation iPod which remain undiagnosed at the time of this writing. Signed-off-by: Stefan Richter --- drivers/ieee1394/sbp2.c | 10 ++++++++++ 1 file changed, 10 insertions(+) Index: linux/drivers/ieee1394/sbp2.c =================================================================== --- linux.orig/drivers/ieee1394/sbp2.c +++ linux/drivers/ieee1394/sbp2.c @@ -395,6 +395,16 @@ static const struct { .model = SBP2_ROM_VALUE_WILDCARD, .workarounds = SBP2_WORKAROUND_128K_MAX_TRANS, }, + /* + * iPod 2nd generation: needs 128k max transfer size workaround + * iPod 3rd generation: needs fix capacity workaround + */ + { + .firmware_revision = 0x0a2700, + .model = 0x000000, + .workarounds = SBP2_WORKAROUND_128K_MAX_TRANS | + SBP2_WORKAROUND_FIX_CAPACITY, + }, /* iPod 4th generation */ { .firmware_revision = 0x0a2700, .model = 0x000021, -- Stefan Richter -=====-==--= ---= ===-= http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/