Message-ID: <4980E785.9010302@goop.org>
Date: Wed, 28 Jan 2009 15:17:25 -0800
From: Jeremy Fitzhardinge <jeremy@goop.org>
User-Agent: Thunderbird 2.0.0.19 (X11/20090105)
MIME-Version: 1.0
To: Zachary Amsden <zach@vmware.com>
CC: "H. Peter Anvin" <hpa@zytor.com>, Ian Campbell <Ian.Campbell@citrix.com>,
       Ingo Molnar <mingo@elte.hu>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC WIP] x86/paravirt: add register-saving thunks to	reduce
 caller register pressure
References: <4980A07D.3010008@goop.org> <1233183903.16317.242.camel@bodhitayantram.eng.vmware.com>
In-Reply-To: <1233183903.16317.242.camel@bodhitayantram.eng.vmware.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 991
Lines: 35

Zachary Amsden wrote:
>> Standard calling convention is:
>>          arguments          return      scratch
>> x86-32   eax edx ecx        eax         ?
>>     
>
> ecx, edx
>   

OK, no scratch beyond the arg regs.

>> XXX Deal with VMI.  What's their calling convention?
>>     
>
> Enable/Disable have no clobbers at all.
> Save clobbers only return value, %eax
> Restore also clobbers nothing.
>   

OK, they can be plugged in directly then.  Use __PV_IS_CALLEE_SAVE(func) 
to wrap it up in the right type.

> The patching code has gotten quite complex with the 32/64 union; let me
> apply it first and see before I comment on the patch.
>   

OK.  I just posted updated versions of this series, so make sure you 
comment on that one.

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/