Subject: Re: [PATCH 5/6] module: make modversion_info contain a pointer,
	not an array.
From: Jon Masters <jonathan@jonmasters.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Arjan van de Ven <arjan@infradead.org>, linux-kernel@vger.kernel.org,
       Shawn Bohrer <shawn.bohrer@gmail.com>
In-Reply-To: <200901290859.40725.rusty@rustcorp.com.au>
References: <200901290005.52819.rusty@rustcorp.com.au>
	 <20090128065231.64d12ffd@infradead.org>
	 <200901290859.40725.rusty@rustcorp.com.au>
Content-Type: text/plain
Organization: World Organi[sz]ation of Broken Dreams
Date: Thu, 29 Jan 2009 01:50:23 -0500
Message-Id: <1233211823.3937.1.camel@perihelion.bos.jonmasters.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 880
Lines: 21

On Thu, 2009-01-29 at 08:59 +1030, Rusty Russell wrote:

> We did discuss changing modversions not to descend more than
> one level deep into types (ie. MODVERSION(int fn(struct foo *))
> would depend on the type of struct foo, but not the type of any
> struct pointers in struct foo) to reduce the problem where header
> changes cause type definitions to be exposed or hidden and thus
> change the modversion.

Yeah. We looked at that for a certain Enterprise Linux distribution but
various people suggested it was more hassle than it was worth to get it
right. I did do some initial poking - I'll dig it up and post it here.

Jon.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/