Date: Thu, 29 Jan 2009 08:37:53 +0100
Message-ID: <s5hskn2a7fy.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: Don't cold reset AC97 codecs in some ICH chipsets
In-Reply-To: <20090128155258.GA4646@vespa.holoscopio.com>
References: <1233153642-4882-1-git-send-email-cascardo@holoscopio.com>
	<s5hr62nv4nn.wl%tiwai@suse.de>
	<20090128155258.GA4646@vespa.holoscopio.com>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3
 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2047
Lines: 56

At Wed, 28 Jan 2009 13:52:59 -0200,
Thadeu Lima de Souza Cascardo wrote:
> 
> On Wed, Jan 28, 2009 at 04:20:12PM +0100, Takashi Iwai wrote:
> > At Wed, 28 Jan 2009 12:40:42 -0200,
> > Thadeu Lima de Souza Cascardo wrote:
> > > 
> > > Check in a quirk list if it should do cold reset when AC97 power saving
> > > is enabled. Some devices do not resume properly when cold reset,
> > > although power saving works OK.
> > > 
> > > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
> > 
> > Thanks, applied now.
> > 
> > ... and soon I found a build error when CONFIG_SND_AC97_POWERSAVE=n.
> > Fixed, too :)
> 
> 
> Sorry for this one. I've cleaned the modules and built them again with a
> changed config. Must have done something wrong in the build. Thanks for
> the fix.
> 
> Regarding the warning fix in 92aab0a0, it is related to this commit:
> 248c982a, which was proposed by you during our previous discussion, and
> didn't really fix my problem.

I can't find these commit ids.  Which tree are you referring to?


thanks,

Takashi

> I've been watching your tree ever since and this patch has been in your
> master branch since then, perhaps awaiting some conclusion about this
> issue.
> 
> Do you think it solves any problems for other device models? In my case,
> if the cold reset was done, this would simply not work.
> 
> Looking closer to the patch now, I see a point in keeping it, which may
> be the reason you did so. It will make the resume faster in those cases
> the init_bits are different from what the driver though would be there.
> 
> In this case, I think the log message should be more clear about that,
> since it seems to indicate that the commit makes the driver wait for
> more codecs (all codec slots) than before the commit.
> 
> Regards,
> Cascardo.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/