Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756218AbZA2IH0 (ORCPT ); Thu, 29 Jan 2009 03:07:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751717AbZA2IHM (ORCPT ); Thu, 29 Jan 2009 03:07:12 -0500 Received: from cantor2.suse.de ([195.135.220.15]:32989 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751332AbZA2IHK (ORCPT ); Thu, 29 Jan 2009 03:07:10 -0500 Date: Thu, 29 Jan 2009 09:07:09 +0100 Message-ID: From: Takashi Iwai To: Thadeu Lima de Souza Cascardo Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] AC97: Print AC97 flags in proc file to make debug it easier In-Reply-To: <1233164362-12635-1-git-send-email-cascardo@holoscopio.com> References: <1233164362-12635-1-git-send-email-cascardo@holoscopio.com> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1327 Lines: 39 At Wed, 28 Jan 2009 15:39:22 -0200, Thadeu Lima de Souza Cascardo wrote: > > While debugging some code paths in AC97 codec patches and its suspend > and resume functions, getting to know the flags has proved useful to > follow those code paths. > > Signed-off-by: Thadeu Lima de Souza Cascardo Applied. Thanks. Takashi > --- > sound/pci/ac97/ac97_proc.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/sound/pci/ac97/ac97_proc.c b/sound/pci/ac97/ac97_proc.c > index 060ea59..73b17d5 100644 > --- a/sound/pci/ac97/ac97_proc.c > +++ b/sound/pci/ac97/ac97_proc.c > @@ -125,6 +125,8 @@ static void snd_ac97_proc_read_main(struct snd_ac97 *ac97, struct snd_info_buffe > snd_iprintf(buffer, "PCI Subsys Device: 0x%04x\n\n", > ac97->subsystem_device); > > + snd_iprintf(buffer, "Flags: %x\n", ac97->flags); > + > if ((ac97->ext_id & AC97_EI_REV_MASK) >= AC97_EI_REV_23) { > val = snd_ac97_read(ac97, AC97_INT_PAGING); > snd_ac97_update_bits(ac97, AC97_INT_PAGING, > -- > 1.6.0.6 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/