Message-ID: <498176A0.3020202@goop.org>
Date: Thu, 29 Jan 2009 01:28:00 -0800
From: Jeremy Fitzhardinge <jeremy@goop.org>
User-Agent: Thunderbird 2.0.0.19 (X11/20090105)
MIME-Version: 1.0
To: Rusty Russell <rusty@rustcorp.com.au>
CC: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org,
       Xen-devel <xen-devel@lists.xensource.com>,
       the arch/x86 maintainers <x86@kernel.org>,
       Ian Campbell <ian.campbell@citrix.com>,
       Zachary Amsden <zach@vmware.com>,
       Ravikiran Thirumalai <kiran@scalemp.com>
Subject: Re: [PATCH 3 of 7] x86: fix paravirt clobber in entry_64.S
References: <patchbomb.1233182100@abulafia.goop.org> <138b9e1650b385d5ac9d.1233182103@abulafia.goop.org> <200901291909.18929.rusty@rustcorp.com.au>
In-Reply-To: <200901291909.18929.rusty@rustcorp.com.au>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 993
Lines: 26

Rusty Russell wrote:
> On Thursday 29 January 2009 09:05:03 Jeremy Fitzhardinge wrote:
>   
>> The clobber is trying to say that anything except RDI is available for
>> clobbering, but actually clobbers everything.  This hasn't mattered
>> because the clobbers were basically ignored, but subsequent patches
>> will rely on them.
>>
>> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
>>     
>
> Acked-by: Rusty Russell <rusty@rustcorp.com.au>
>
> Hmm, did we never have the deliberate-clobbering debug code for 64 bit?
>   

No.  I think I killed it off before 64-bit was even started.  There was 
some confusion about whether the return regs were considered to be 
"clobbered" or not, but I don't remember the details.

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/