Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757200AbZA2Kf2 (ORCPT ); Thu, 29 Jan 2009 05:35:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751176AbZA2KfS (ORCPT ); Thu, 29 Jan 2009 05:35:18 -0500 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:56450 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751118AbZA2KfR (ORCPT ); Thu, 29 Jan 2009 05:35:17 -0500 Date: Thu, 29 Jan 2009 10:35:06 +0000 From: Russell King - ARM Linux To: Paul Walmsley Cc: linux-arm-kernel@lists.arm.linux.org.uk, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Tony Lindgren , Tero Kristo Subject: Re: [PATCH C 08/13] OMAP3 clock: put DPLL into bypass if bypass rate = clk->rate, not hardware rate Message-ID: <20090129103506.GC12627@n2100.arm.linux.org.uk> References: <20090128190724.12092.22239.stgit@localhost.localdomain> <20090128190829.12092.86115.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090128190829.12092.86115.stgit@localhost.localdomain> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1241 Lines: 27 On Wed, Jan 28, 2009 at 12:08:32PM -0700, Paul Walmsley wrote: > When a non-CORE DPLL is enabled via omap3_noncore_dpll_enable(), use > the user's desired rate in clk->rate to determine whether to put the > DPLL into bypass or lock mode, rather than reading the DPLL's current > idle state from its hardware registers. > > This fixes a bug observed when leaving retention. Non-CORE DPLLs were > not being relocked when downstream clocks re-enabled; rather, the DPLL > entered bypass mode. > > Problem reported by Tero Kristo . > > linux-omap source commit is 8b1f0bd44fe490ec631230c8c040753a2bda8caa. > > Signed-off-by: Paul Walmsley > Signed-off-by: Tony Lindgren > Cc: Tero Kristo Patch 6 did it this way. Patch 7 changed it to use omap2_get_dpll_rate() and this patch changes it back. What's the point of submitting all this detail? It's just pure noise. Collapse these three patches into one please. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/