Date: Thu, 29 Jan 2009 07:29:38 -0800
From: Arjan van de Ven <arjan@infradead.org>
To: tom.leiming@gmail.com
Cc: kay.sievers@vrfy.org, greg@kroah.com, linux-kernel@vger.kernel.org,
       Ming Lei <tom.leiming@gmail.com>
Subject: Re: [PATCH] driver core: remove polling for driver_probe_done
Message-ID: <20090129072938.2761a6ed@infradead.org>
In-Reply-To: <1233242110-5422-1-git-send-email-tom.leiming@gmail.com>
References: <1233242110-5422-1-git-send-email-tom.leiming@gmail.com>
Organization: Intel
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 849
Lines: 28

> @@ -396,9 +396,9 @@ void __init prepare_namespace(void)
>  	if ((ROOT_DEV == 0) && root_wait) {
>  		printk(KERN_INFO "Waiting for root device %s...\n",
>  			saved_root_name);
> -		while (driver_probe_done() != 0 ||
> -			(ROOT_DEV = name_to_dev_t(saved_root_name))
> == 0)
> -			msleep(100);
> +		ROOT_DEV = name_to_dev_t(saved_root_name);
> +		if (ROOT_DEV)
> +			driver_probe_wait_done();
>  	}
>  

Hi,

another comment:

this is not equivalent

you turned "wait until all probing is done OR until the device exists"
into "wait until all probing is done"... which might be several seconds
longer!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/