Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754466AbZA3PNh (ORCPT ); Fri, 30 Jan 2009 10:13:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750949AbZA3PN3 (ORCPT ); Fri, 30 Jan 2009 10:13:29 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:43662 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750824AbZA3PN2 (ORCPT ); Fri, 30 Jan 2009 10:13:28 -0500 Date: Fri, 30 Jan 2009 16:12:51 +0100 From: Ingo Molnar To: Eduard - Gabriel Munteanu Cc: Randy Dunlap , Geert Uytterhoeven , linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH -next/mmotm/resend] kmemtrace: fix printk formats Message-ID: <20090130151251.GC27549@elte.hu> References: <200901291030.n0TAUhRI003046@imap1.linux-foundation.org> <4981E86F.60909@oracle.com> <49822479.9030908@oracle.com> <20090130074645.GA5218@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090130074645.GA5218@localhost> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1862 Lines: 55 * Eduard - Gabriel Munteanu wrote: > On Thu, Jan 29, 2009 at 01:49:45PM -0800, Randy Dunlap wrote: > > Geert Uytterhoeven wrote: > > > > > > %4zu? > > > > Ugh, yes. Thanks. > > Here's the updated patch. > > > > -- > > From: Randy Dunlap > > > > Fix kmemtrace printk warnings: > > > > kernel/trace/kmemtrace.c:142: warning: format '%4ld' expects type 'long int', but argument 3 has type 'size_t' > > kernel/trace/kmemtrace.c:147: warning: format '%4ld' expects type 'long int', but argument 3 has type 'size_t' > > > > Signed-off-by: Randy Dunlap > > cc: Eduard - Gabriel Munteanu > > --- > > kernel/trace/kmemtrace.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > --- linux-next-20090123.orig/kernel/trace/kmemtrace.c > > +++ linux-next-20090123/kernel/trace/kmemtrace.c > > @@ -139,12 +139,12 @@ kmemtrace_print_alloc_compress(struct tr > > return TRACE_TYPE_PARTIAL_LINE; > > > > /* Requested */ > > - ret = trace_seq_printf(s, "%4ld ", entry->bytes_req); > > + ret = trace_seq_printf(s, "%4zu ", entry->bytes_req); > > if (!ret) > > return TRACE_TYPE_PARTIAL_LINE; > > > > /* Allocated */ > > - ret = trace_seq_printf(s, "%4ld ", entry->bytes_alloc); > > + ret = trace_seq_printf(s, "%4zu ", entry->bytes_alloc); > > if (!ret) > > return TRACE_TYPE_PARTIAL_LINE; > > > > I didn't notice this either, thanks. > > Acked-by: Eduard - Gabriel Munteanu Applied to tip/tracing/kmemtrace, thanks! Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/