Date: Fri, 30 Jan 2009 13:40:09 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: sandeen@redhat.com, linux-fsdevel@vger.kernel.org,
       linux-kernel@vger.kernel.org, t-sato@yk.jp.nec.com
Subject: Re: [PATCH V3] Allow SysRq emergency thaw to thaw frozen
 filesystems
Message-Id: <20090130134009.02d4a576.akpm@linux-foundation.org>
In-Reply-To: <4970E4FB.7040407@redhat.com>
References: <496EB639.6090800@redhat.com>
	<4970E087.8020308@redhat.com>
	<4970E4FB.7040407@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1053
Lines: 34

On Fri, 16 Jan 2009 13:50:19 -0600
Eric Sandeen <sandeen@redhat.com> wrote:

> +void do_thaw_all(unsigned long unused)
> +{
> +	struct super_block *sb;
> +	char b[BDEVNAME_SIZE];
> +
> +	list_for_each_entry(sb, &super_blocks, s_list) {
> +		while (sb->s_bdev && !thaw_bdev(sb->s_bdev, sb))
> +			printk(KERN_WARNING "Emergency Thaw on %s\n",
> +			       bdevname(sb->s_bdev, b));
> +	}
> +	printk(KERN_WARNING "Emergency Thaw complete\n");
> +}

Is there any reason why we're not taking the appropriate locks here?

If so, please add a comment justifying the implementation.

> +/**
> + * emergency_thaw_all -- forcibly thaw every frozen filesystem
> + *
> + * Used for emergency unfreeze of all filesystems via SysRq
> + */
> +void emergency_thaw_all(void)
> +{
> +	pdflush_operation(do_thaw_all, 0);
> +}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/