Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756069AbZAaAoq (ORCPT ); Fri, 30 Jan 2009 19:44:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752539AbZAaAof (ORCPT ); Fri, 30 Jan 2009 19:44:35 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:50247 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752258AbZAaAof (ORCPT ); Fri, 30 Jan 2009 19:44:35 -0500 Date: Sat, 31 Jan 2009 01:44:16 +0100 From: Ingo Molnar To: "Rafael J. Wysocki" Cc: Parag Warudkar , Linus Torvalds , Matt Carlson , "netdev@vger.kernel.org" , Linux Kernel Mailing List , "David S. Miller" , Andrew Morton Subject: Re: 2.6.29-rc3: tg3 dead after resume Message-ID: <20090131004416.GC13709@elte.hu> References: <200901310059.17746.rjw@sisk.pl> <200901310138.51214.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200901310138.51214.rjw@sisk.pl> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1018 Lines: 34 * Rafael J. Wysocki wrote: > +static struct dev_pm_ops pcie_portdrv_pm_ops = { > + .suspend = pcie_port_device_suspend, > + .resume = pcie_port_device_resume, > + .freeze = pcie_port_device_suspend, > + .thaw = pcie_port_device_resume, > + .poweroff = pcie_port_device_suspend, > + .restore = pcie_port_device_resume, > +}; pet peeve: could we please use vertical spaces wherever they improve the code? Something like: static struct dev_pm_ops pcie_portdrv_pm_ops = { .suspend = pcie_port_device_suspend, .resume = pcie_port_device_resume, .freeze = pcie_port_device_suspend, .thaw = pcie_port_device_resume, .poweroff = pcie_port_device_suspend, .restore = pcie_port_device_resume, }; ... and it all becomes clear at a glance. Please? Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/