Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756229AbZAaAr7 (ORCPT ); Fri, 30 Jan 2009 19:47:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752310AbZAaArs (ORCPT ); Fri, 30 Jan 2009 19:47:48 -0500 Received: from ogre.sisk.pl ([217.79.144.158]:51084 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752137AbZAaArr (ORCPT ); Fri, 30 Jan 2009 19:47:47 -0500 From: "Rafael J. Wysocki" To: Ingo Molnar Subject: Re: 2.6.29-rc3: tg3 dead after resume Date: Sat, 31 Jan 2009 01:47:02 +0100 User-Agent: KMail/1.10.3 (Linux/2.6.29-rc2-tst; KDE/4.1.3; x86_64; ; ) Cc: Parag Warudkar , Linus Torvalds , Matt Carlson , "netdev@vger.kernel.org" , Linux Kernel Mailing List , "David S. Miller" , Andrew Morton References: <200901310138.51214.rjw@sisk.pl> <20090131004416.GC13709@elte.hu> In-Reply-To: <20090131004416.GC13709@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200901310147.02897.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1125 Lines: 37 On Saturday 31 January 2009, Ingo Molnar wrote: > > * Rafael J. Wysocki wrote: > > > +static struct dev_pm_ops pcie_portdrv_pm_ops = { > > + .suspend = pcie_port_device_suspend, > > + .resume = pcie_port_device_resume, > > + .freeze = pcie_port_device_suspend, > > + .thaw = pcie_port_device_resume, > > + .poweroff = pcie_port_device_suspend, > > + .restore = pcie_port_device_resume, > > +}; > > pet peeve: could we please use vertical spaces wherever they improve the > code? > > Something like: > > static struct dev_pm_ops pcie_portdrv_pm_ops = { > .suspend = pcie_port_device_suspend, > .resume = pcie_port_device_resume, > .freeze = pcie_port_device_suspend, > .thaw = pcie_port_device_resume, > .poweroff = pcie_port_device_suspend, > .restore = pcie_port_device_resume, > }; > > ... and it all becomes clear at a glance. Please? OK Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/