Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756041AbZAaBVw (ORCPT ); Fri, 30 Jan 2009 20:21:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752496AbZAaBVk (ORCPT ); Fri, 30 Jan 2009 20:21:40 -0500 Received: from yx-out-2324.google.com ([74.125.44.28]:61580 "EHLO yx-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750992AbZAaBVj (ORCPT ); Fri, 30 Jan 2009 20:21:39 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type; b=q4HMXCUR7awypyGZuAE8oF9CyfhJQTDJatHaPO1LH24y9RA7JEaYBdfLLzU/a3N0R7 v5A2cIOva0r2sg9ez4RU/kQngc5FiLr6fGfJy39fe2dZfg9aoHvDx2gVoY09bgml69K3 pwoNn7URsTy+ImHfnB6pu0RARAEN/9GiTCvsM= Date: Fri, 30 Jan 2009 20:21:28 -0500 (EST) From: Parag Warudkar X-X-Sender: parag@parag-desktop To: "Rafael J. Wysocki" cc: Parag Warudkar , Linus Torvalds , Matt Carlson , "netdev@vger.kernel.org" , Linux Kernel Mailing List , "David S. Miller" , Andrew Morton Subject: Re: 2.6.29-rc3: tg3 dead after resume In-Reply-To: <200901310138.51214.rjw@sisk.pl> Message-ID: References: <200901310059.17746.rjw@sisk.pl> <200901310138.51214.rjw@sisk.pl> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 13303 Lines: 216 On Sat, 31 Jan 2009, Rafael J. Wysocki wrote: > This gets more and more interesting. > > Can you test the patch below, please? > > Rafael > > --- > Subject: PCI PCIe portdrv: Implement pm object > From: Rafael J. Wysocki > > Implement pm object for the PCI Express port driver in order to use > the new power management framework. > > Signed-off-by: Rafael J. Wysocki > --- Excellent! This patch works - tg3 comes back and gets link after resume. Thank you! Are the below differences worth worrying about - especially since post suspend some DevID/VendorID and some capabilities seem to be changed? parag@parag-desktop:~$ diff -u lspci-pre-suspend lspci-post-fix --- lspci-pre-suspend 2009-01-30 18:19:50.752275695 -0500 +++ lspci-post-fix 2009-01-30 20:14:22.605607870 -0500 @@ -286,9 +286,9 @@ 10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 20: 00 00 00 00 00 00 00 00 00 00 00 00 86 80 86 80 30: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 -40: 00 00 00 00 00 00 0d 00 00 00 00 00 00 00 00 00 +40: 00 00 00 00 00 00 0f 00 00 00 00 00 00 00 00 00 50: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 -60: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +60: 00 00 00 00 00 00 00 00 00 01 00 00 00 00 00 00 70: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 @@ -353,7 +353,7 @@ 40: 00 00 00 80 14 14 b0 b0 ff 01 00 30 ff 01 00 30 50: 00 00 00 07 00 00 00 00 ff 3f ff 3f 00 40 00 40 60: 00 40 00 40 01 80 01 80 00 00 00 00 00 00 00 00 -70: 00 00 00 00 6b e0 6b e0 00 00 0b a9 00 00 0b a9 +70: 00 00 00 00 00 c0 00 c0 01 1b 4c b8 01 1b 4c b8 80: 24 07 00 00 00 00 00 00 00 00 00 00 00 00 00 00 90: 01 01 08 00 01 01 08 00 01 01 08 00 01 01 08 00 a0: 01 01 08 00 00 00 00 00 00 00 00 00 00 00 00 00 @@ -395,7 +395,7 @@ 40: 00 00 00 80 14 14 b0 b0 ff 01 00 30 ff 01 00 30 50: 00 00 00 07 00 00 00 00 ff 3f ff 3f 00 40 00 40 60: 00 40 00 40 01 80 01 80 00 00 00 00 00 00 00 00 -70: 00 00 00 00 69 e0 69 e0 00 00 0b a9 00 00 0b a9 +70: 00 00 00 00 00 40 00 40 01 1b 4c b8 01 1b 4c b8 80: 65 06 00 00 00 00 00 00 00 00 00 00 00 00 00 00 90: 01 01 20 00 01 01 20 00 01 01 20 00 01 01 20 00 a0: 01 01 20 00 00 00 00 00 00 00 00 00 00 00 00 00 @@ -645,8 +645,8 @@ 30: 00 00 00 00 50 00 00 00 00 00 00 00 03 01 00 00 40: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 50: 01 58 c2 c9 00 00 00 00 0a 00 a0 20 00 00 00 00 -60: 20 20 ff 01 00 00 00 00 01 00 00 00 00 00 08 80 -70: 00 00 df 3f 00 00 00 00 00 00 00 00 00 00 00 00 +60: 20 20 ff 01 00 00 00 00 01 00 00 00 00 00 08 c0 +70: 00 00 dd 3f 00 00 00 00 00 00 00 00 00 00 00 00 80: 00 00 00 00 01 00 00 00 00 00 00 00 00 00 00 00 90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 @@ -698,7 +698,7 @@ 70: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 80: 10 00 09 14 01 04 00 00 81 04 00 00 00 00 00 00 90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 -a0: 10 06 00 00 01 00 00 00 00 00 00 00 00 13 00 00 +a0: 10 06 00 00 00 00 00 00 00 00 00 00 00 13 00 00 b0: 00 00 00 00 00 00 00 00 00 10 00 04 00 00 00 00 c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 d0: 33 22 11 00 67 45 00 00 c0 c0 00 00 02 00 00 00 @@ -754,7 +754,7 @@ Capabilities: [50] Vital Product Data Capabilities: [58] Vendor Specific Information Capabilities: [e8] Message Signalled Interrupts: Mask- 64bit+ Queue=0/0 Enable+ - Address: 00000000fee0f00c Data: 41c1 + Address: 00000000fee0f00c Data: 41c9 Capabilities: [d0] Express (v1) Endpoint, MSI 00 DevCap: MaxPayload 128 bytes, PhantFunc 0, Latency L0s <4us, L1 unlimited ExtTag+ AttnBtn- AttnInd- PwrInd- RBE+ FLReset- @@ -778,24 +778,24 @@ 20: 00 00 00 00 00 00 00 00 00 00 00 00 3c 10 07 13 30: 00 00 04 20 48 00 00 00 00 00 00 00 03 01 00 00 40: 00 00 00 00 00 00 00 00 01 50 03 c0 08 20 00 64 -50: 03 58 fc 00 00 00 00 78 09 e8 78 00 95 ef 08 88 +50: 03 58 fc 00 00 00 00 78 09 e8 78 00 9a f7 08 58 60: 00 00 00 00 00 00 00 00 98 02 02 a0 00 00 18 76 70: f2 10 00 00 c0 00 00 00 20 70 00 00 00 00 00 00 80: 00 00 00 00 00 00 00 00 34 00 13 04 82 70 08 fc -90: 19 be 00 01 00 00 00 00 00 00 00 00 94 01 00 00 -a0: 00 00 00 00 cc 00 00 00 00 00 00 00 29 01 00 00 -b0: 00 00 00 00 00 00 00 8e 00 00 00 00 00 00 00 00 +90: 19 be 00 01 00 00 00 44 00 00 00 00 e7 00 00 00 +a0: 00 00 00 00 1f 00 00 00 00 00 00 00 24 00 00 00 +b0: 00 00 00 00 00 00 00 44 00 00 00 00 00 00 00 00 c0: 00 00 00 00 00 00 00 00 0e 00 00 00 00 00 00 00 d0: 10 00 01 00 a0 8f 00 00 00 50 10 00 11 64 03 00 e0: 40 00 11 10 00 00 00 00 05 d0 81 00 0c f0 e0 fe -f0: 00 00 00 00 c1 41 00 00 00 00 00 00 00 00 00 00 +f0: 00 00 00 00 c9 41 00 00 00 00 00 00 00 00 00 00 10:00.0 PCI bridge: Intel Corporation 6311ESB/6321ESB PCI Express Upstream Port (rev 01) Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- SERR- TAbort- TAbort- Reset- FastB2B- PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn- Capabilities: [44] Express (v1) Upstream Port, MSI 00 @@ -818,7 +818,7 @@ Kernel driver in use: pcieport-driver Kernel modules: shpchp 00: 86 80 00 35 07 01 10 00 01 00 04 06 10 00 81 00 -10: 00 00 00 00 00 00 00 00 10 1e 40 00 f0 00 00 20 +10: 00 00 00 00 00 00 00 00 10 1e 40 00 f0 00 00 00 20: f0 ff 00 00 f1 ff 01 00 00 00 00 00 00 00 00 00 30: 00 00 00 00 44 00 00 00 00 00 00 00 ff 01 06 00 40: 00 28 02 10 10 70 51 00 01 00 00 00 0f 50 0a 00 @@ -839,7 +839,7 @@ Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- SERR- TAbort- TAbort- Reset- FastB2B- PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn- Capabilities: [44] Express (v1) PCI/PCI-X Bridge, MSI 00 @@ -848,7 +848,7 @@ DevCtl: Report errors: Correctable- Non-Fatal- Fatal- Unsupported- RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop- BrConfRtry- MaxPayload 128 bytes, MaxReadReq 512 bytes - DevSta: CorrErr- UncorrErr+ FatalErr- UnsuppReq+ AuxPwr- TransPend- + DevSta: CorrErr- UncorrErr- FatalErr- UnsuppReq- AuxPwr- TransPend- LnkCap: Port #0, Speed 2.5GT/s, Width x8, ASPM L0s, Latency L0 unlimited, L1 unlimited ClockPM- Suprise- LLActRep- BwNot- LnkCtl: ASPM Disabled; Disabled- Retrain- CommClk- @@ -857,7 +857,7 @@ Capabilities: [6c] Power Management version 2 Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0+,D1-,D2-,D3hot+,D3cold+) Status: D0 PME-Enable- DSel=0 DScale=0 PME- - Capabilities: [80] Subsystem: Hewlett-Packard Company Device 1307 + Capabilities: [80] Subsystem: Gammagraphx, Inc. Device 0000 Capabilities: [d8] PCI-X bridge device Secondary Status: 64bit+ 133MHz+ SCD- USC- SCO- SRD- Freq=133MHz Status: Dev=00:00.3 64bit- 133MHz- SCD- USC- SCO- SRD- @@ -866,14 +866,14 @@ Capabilities: [100] Advanced Error Reporting Kernel modules: shpchp 00: 86 80 0c 35 07 01 10 00 01 00 04 06 10 00 81 00 -10: 00 00 00 00 00 00 00 00 10 11 1d 20 f0 00 a0 22 +10: 00 00 00 00 00 00 00 00 10 11 1d 20 f0 00 a0 02 20: f0 ff 00 00 f1 ff 01 00 00 00 00 00 00 00 00 00 30: 00 00 00 00 44 00 00 00 00 00 00 00 00 00 06 00 -40: 80 6e 00 ff 10 6c 71 00 01 00 00 00 00 20 0a 00 +40: 80 6e 00 ff 10 6c 71 00 01 00 00 00 00 20 00 00 50: 81 f4 03 00 00 00 41 00 00 00 00 00 05 6c 80 00 60: 00 00 00 00 00 00 00 00 00 00 00 00 01 80 02 c8 70: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 -80: 0d d8 00 00 3c 10 07 13 00 00 00 00 00 00 00 00 +80: 0d d8 00 00 00 00 00 00 00 00 00 00 00 00 00 00 90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 @@ -916,7 +916,7 @@ 20: f0 ff 00 00 f1 ff 01 00 00 00 00 00 00 00 00 00 30: 00 00 00 00 44 00 00 00 00 00 00 00 00 01 06 00 40: 00 00 c0 00 10 60 61 00 01 00 00 00 0f 50 00 00 -50: 41 f4 03 00 20 00 01 10 80 0c 00 00 c0 03 48 00 +50: 41 f4 03 00 20 00 01 10 80 0c 00 00 c0 03 58 00 60: 05 70 81 00 0c f0 e0 fe 00 00 00 00 91 41 00 00 70: 01 80 02 c8 00 00 00 00 00 00 00 00 00 00 00 00 80: 0d 00 00 00 3c 10 07 13 00 00 00 00 00 00 00 00 @@ -962,7 +962,7 @@ 20: f0 ff 00 00 f1 ff 01 00 00 00 00 00 00 00 00 00 30: 00 00 00 00 44 00 00 00 00 00 00 00 00 01 06 00 40: 00 00 c0 00 10 60 61 00 01 00 00 00 0f 50 00 00 -50: 41 f4 03 00 20 00 01 10 80 0c 00 00 c0 03 48 00 +50: 41 f4 03 00 20 00 01 10 80 0c 00 00 c0 03 58 00 60: 05 70 81 00 0c f0 e0 fe 00 00 00 00 99 41 00 00 70: 01 80 02 c8 00 00 00 00 00 00 00 00 00 00 00 00 80: 0d 00 00 00 3c 10 07 13 00 00 00 00 00 00 00 00 parag@parag-desktop:~$ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/