Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754090AbZAaC0T (ORCPT ); Fri, 30 Jan 2009 21:26:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751969AbZAaC0A (ORCPT ); Fri, 30 Jan 2009 21:26:00 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:36249 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751690AbZAaCZ7 (ORCPT ); Fri, 30 Jan 2009 21:25:59 -0500 Date: Fri, 30 Jan 2009 18:25:24 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Parag Warudkar cc: "Rafael J. Wysocki" , Matt Carlson , "netdev@vger.kernel.org" , Linux Kernel Mailing List , "David S. Miller" , Andrew Morton Subject: Re: 2.6.29-rc3: tg3 dead after resume In-Reply-To: Message-ID: References: <200901310059.17746.rjw@sisk.pl> <200901310138.51214.rjw@sisk.pl> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1312 Lines: 30 On Fri, 30 Jan 2009, Parag Warudkar wrote: > > Ok - I will run with it temporarily and will do what I can to track down > what was wrong with the legacy PM. If you can try the patch I just sent out, and use that as a base for trying to track down why the heck the legacy code doesn't work, that would be great. It might fix it (assuming my guess about "restore_state while in PCI_D3 doesn't work" was correct), but quite frankly, it's equally possible that it just makes things worse. But it would be really interesting to hear.. Your machine does seem to be interesting, in that not only does it have a PCI-E bridge in it (the eeepc I was playing around with at LCA does not), but judging by the lost config state I also suspect that it actually loses power during STR. Which is not at all necessarily a given - I suspect it depends on just how the power rails are set up on the motherboard. The fact that PCI-E bridges have apparently worked for others implies that your problems don't happen for everybody, and may relate to that issue. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/