Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753873AbZAaLki (ORCPT ); Sat, 31 Jan 2009 06:40:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751896AbZAaLk3 (ORCPT ); Sat, 31 Jan 2009 06:40:29 -0500 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:34076 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751188AbZAaLk1 (ORCPT ); Sat, 31 Jan 2009 06:40:27 -0500 Date: Sat, 31 Jan 2009 11:40:14 +0000 From: Russell King - ARM Linux To: "Woodruff, Richard" Cc: Paul Walmsley , "linux-arm-kernel@lists.arm.linux.org.uk" , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" , Tony Lindgren Subject: Re: [PATCH E 08/14] OMAP clock: move rate recalc, propagation code up to plat-omap/clock.c Message-ID: <20090131114014.GD1394@n2100.arm.linux.org.uk> References: <20090128192551.29333.82943.stgit@localhost.localdomain> <20090128192748.29333.5856.stgit@localhost.localdomain> <20090129174153.GH18233@n2100.arm.linux.org.uk> <20090130085249.GB6864@n2100.arm.linux.org.uk> <13B9B4C6EF24D648824FF11BE89671620376DEC116@dlee02.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <13B9B4C6EF24D648824FF11BE89671620376DEC116@dlee02.ent.ti.com> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1315 Lines: 27 On Fri, Jan 30, 2009 at 08:23:49AM -0600, Woodruff, Richard wrote: > > > There's one bug that your version highlights in mine - the virtual mpu > > clock in omap1 touches the DPLL and repropagates that rate. I've > > removed that repropagation, so that needs fixing. > > > > However, this raises a question: why is the virtual mpu clock touching > > some other part of the clock tree. I wonder whether this should be > > handled a different way, though the first thing that needs answering is > > why we have this alias for 'arm_ck' ? > > At one point in time the virtual clock allowed control for a set of clocks > with some dependencies. The mpu alias provided a convenient control point. >From what I can see (checking both mainline and Tony's tree), this mpu alias (virtual_ck_mpu) is not used on OMAP1, which seems to suggest that this quirk has become redundant. If it is redundant, it should be removed. If there is some code somewhere to use it, this quirk should live with the user of the quirk until such time that the user becomes ready to be merged. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/