DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:subject
         :content-type:content-transfer-encoding;
        b=VyHKMYPxJY/AQFDTh4CP32lwPKlSej0TjRjECl9HeMJLR4cKWdjuDX1svOxNijBIki
         04fSLQxsMd4UXyTtAC/1qBqAQ6RfkDbl8057nRfgmlZElKvono08kWZ2AvBibj8JKGTG
         2ch72fGPwo/fE6a2Hp57dTTCNAWoL4V7h5nfQ=
Message-ID: <49AB12A7.10708@gmail.com>
Date: Sun, 01 Mar 2009 23:56:39 +0100
From: Roel Kluin <roel.kluin@gmail.com>
User-Agent: Thunderbird 2.0.0.18 (X11/20081105)
MIME-Version: 1.0
To: lkml <linux-kernel@vger.kernel.org>
Subject: lp: too large subtraction on unsigned?
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 515
Lines: 24

vi drivers/char/lp.c +705

note that count is unsigned, and we do the loop:

do {
	if (canwrite > 0) {
		...
		count -= written;
	}
	if (lf && canwrite <= 0) {
		...
		count--;
		...
	}
} while (count > 0 && (CONSOLE_LP_STRICT || written > 0));

Isn't this wrong?

Roel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/